[GitHub] [shardingsphere] strongduanmu commented on a change in pull request #12896: support INSERT SELECT on encrypt

[GitBox <gi...@apache.org>]

strongduanmu commented on a change in pull request #12896:
URL: https://github.com/apache/shardingsphere/pull/12896#discussion_r723992400



##########
File path: shardingsphere-infra/shardingsphere-infra-binder/src/main/java/org/apache/shardingsphere/infra/binder/segment/table/TablesContext.java
##########
@@ -152,8 +152,9 @@ public TablesContext(final Collection<SimpleTableSegment> tableSegments) {
             if (tableColumnNames.isEmpty()) {
                 continue;
             }
-            tableColumnNames.retainAll(columnNames);
-            for (String columnName : tableColumnNames) {
+            //tableColumnNames.retainAll(columnNames);

Review comment:
       @cheese8 Can you remove this inline comment?

##########
File path: shardingsphere-test/shardingsphere-rewrite-test/src/test/resources/scenario/encrypt/case/insert.xml
##########
@@ -67,6 +67,11 @@
         <output sql="INSERT INTO t_account(account_id, cipher_certificate_number, assisted_query_certificate_number, cipher_password, assisted_query_password, cipher_amount, status) VALUES (?, ?, ?, ?, ?, ?, ?), (2, 'encrypt_222X', 'assisted_query_222X', 'encrypt_bbb', 'assisted_query_bbb', 'encrypt_2000', 'OK'), (?, ?, ?, ?, ?, ?, ?), (4, 'encrypt_444X', 'assisted_query_444X', 'encrypt_ddd', 'assisted_query_ddd', 'encrypt_4000', 'OK')" parameters="1, encrypt_111X, assisted_query_111X, encrypt_aaa, assisted_query_aaa, encrypt_1000, OK, 3, encrypt_333X, assisted_query_333X, encrypt_ccc, assisted_query_ccc, encrypt_3000, OK" />
     </rewrite-assertion>
     
+    <rewrite-assertion id="insert_select_encrypt_rewrite">

Review comment:
       @cheese8 Can this sql execute successfully?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org