[GitHub] [solr] dsmiley commented on a change in pull request #635: SOLR-16006: Fix declared/unused dependency warnings

[GitBox <gi...@apache.org>]

dsmiley commented on a change in pull request #635:
URL: https://github.com/apache/solr/pull/635#discussion_r806287123



##########
File path: solr/server/build.gradle
##########
@@ -30,39 +30,62 @@ configurations {
 }
 
 dependencies {
-  api('org.eclipse.jetty:jetty-alpn-java-server', {
-    exclude group: "org.eclipse.jetty.alpn", module: "alpn-api"
-  })
-
+  permitUnusedDeclared 'io.dropwizard.metrics:metrics-core'
   api('io.dropwizard.metrics:metrics-core', {
     exclude group: "com.rabbitmq", module: "amqp-client"
   })
+  permitUnusedDeclared 'io.dropwizard.metrics:metrics-graphite'
   api('io.dropwizard.metrics:metrics-graphite', {
     exclude group: "com.rabbitmq", module: "amqp-client"
   })
+  permitUnusedDeclared 'io.dropwizard.metrics:metrics-jetty9'
   api 'io.dropwizard.metrics:metrics-jetty9'
+  permitUnusedDeclared 'io.dropwizard.metrics:metrics-jvm'
   api 'io.dropwizard.metrics:metrics-jvm'
+  permitUnusedDeclared 'io.dropwizard.metrics:metrics-jmx'
   api 'io.dropwizard.metrics:metrics-jmx'

Review comment:
       Maybe these shouldn't be `api` in the first place?

##########
File path: solr/modules/s3-repository/build.gradle
##########
@@ -20,70 +20,70 @@ apply plugin: 'java-library'
 description = 'S3 Repository'
 
 dependencies {
-    api project(':solr:core')
-    implementation project(':solr:solrj')
+  api project(':solr:core')
+  implementation project(':solr:solrj')
 
-    implementation 'org.apache.lucene:lucene-core'
+  implementation 'org.apache.lucene:lucene-core'

Review comment:
       if we make this "api" on solr-core, then would we _still_ need to declare this here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org