[GitHub] [airflow] ashb commented on a change in pull request #14625: Support remote logging in elasticsearch with filebeat 7

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #14625:
URL: https://github.com/apache/airflow/pull/14625#discussion_r650031960



##########
File path: airflow/providers/elasticsearch/log/es_task_handler.py
##########
@@ -71,6 +72,8 @@ def __init__(  # pylint: disable=too-many-arguments
         write_stdout: bool,
         json_format: bool,
         json_fields: str,
+        host_field: str,
+        offset_field: str,

Review comment:
       So, we have a bit of a chicken and egg problem here.
   
   The config is going to be added in 2.1.1, but the ES logger is now in a provider, and that provider could be installed against Airflow 2.1.0.
   
   So I think we have to do this
   
   ```suggestion
           host_field: str = "host",
           offset_field: str = "offset",
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org