You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Zhitao Li <zh...@gmail.com> on 2016/12/22 17:12:29 UTC
Review Request 54986: Added metric for slave message queue.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54986/
-----------------------------------------------------------
Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Jason Lai.
Bugs: MESOS-6831
https://issues.apache.org/jira/browse/MESOS-6831
Repository: mesos
Description
-------
Added metric for slave message queue.
Diffs
-----
src/slave/metrics.hpp 3fc933ca65690d6fad63156398ad9c2c53789296
src/slave/metrics.cpp 0eb2b59ed67e14e73b29d7592c239441df0008d5
src/slave/slave.hpp be72ba93d4c6ca3e69e3f76f87aa7ddebdbf9cad
src/tests/slave_tests.cpp fc6b56c074c71b827a9ee522cd715c0d15ecc7e3
Diff: https://reviews.apache.org/r/54986/diff/
Testing
-------
make check.
Thanks,
Zhitao Li
Re: Review Request 54986: Added metric for slave message queue.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54986/#review167536
-----------------------------------------------------------
Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md) for reopening reviews.
- Joris Van Remoortere
On Dec. 22, 2016, 5:12 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54986/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2016, 5:12 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Jason Lai.
>
>
> Bugs: MESOS-6831
> https://issues.apache.org/jira/browse/MESOS-6831
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added metric for slave message queue.
>
>
> Diffs
> -----
>
> src/slave/metrics.hpp 3fc933ca65690d6fad63156398ad9c2c53789296
> src/slave/metrics.cpp 0eb2b59ed67e14e73b29d7592c239441df0008d5
> src/slave/slave.hpp be72ba93d4c6ca3e69e3f76f87aa7ddebdbf9cad
> src/tests/slave_tests.cpp fc6b56c074c71b827a9ee522cd715c0d15ecc7e3
>
>
> Diff: https://reviews.apache.org/r/54986/diff/1/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 54986: Added metric for slave message queue.
Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54986/
-----------------------------------------------------------
(Updated April 30, 2018, 2:01 p.m.)
Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Jason Lai.
Bugs: MESOS-6831
https://issues.apache.org/jira/browse/MESOS-6831
Repository: mesos
Description
-------
Added metric for slave message queue.
Diffs
-----
src/slave/metrics.hpp 3fc933ca65690d6fad63156398ad9c2c53789296
src/slave/metrics.cpp 0eb2b59ed67e14e73b29d7592c239441df0008d5
src/slave/slave.hpp be72ba93d4c6ca3e69e3f76f87aa7ddebdbf9cad
src/tests/slave_tests.cpp fc6b56c074c71b827a9ee522cd715c0d15ecc7e3
Diff: https://reviews.apache.org/r/54986/diff/1/
Testing
-------
make check.
Thanks,
Zhitao Li
Re: Review Request 54986: Added metric for slave message queue.
Posted by Jason Lai <ja...@jasonlai.net>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54986/#review159998
-----------------------------------------------------------
Ship it!
LGTM
- Jason Lai
On Dec. 22, 2016, 5:12 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54986/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2016, 5:12 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Jason Lai.
>
>
> Bugs: MESOS-6831
> https://issues.apache.org/jira/browse/MESOS-6831
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added metric for slave message queue.
>
>
> Diffs
> -----
>
> src/slave/metrics.hpp 3fc933ca65690d6fad63156398ad9c2c53789296
> src/slave/metrics.cpp 0eb2b59ed67e14e73b29d7592c239441df0008d5
> src/slave/slave.hpp be72ba93d4c6ca3e69e3f76f87aa7ddebdbf9cad
> src/tests/slave_tests.cpp fc6b56c074c71b827a9ee522cd715c0d15ecc7e3
>
> Diff: https://reviews.apache.org/r/54986/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Zhitao Li
>
>