You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by ec...@apache.org on 2014/08/01 00:08:09 UTC
[33/50] [abbrv] git commit: [HBASE-9704] HLog profiling will fail to
work.
[HBASE-9704] HLog profiling will fail to work.
Summary: HLog profiling will not work anymore as we move more towards an asynchronous HRegionServer. The profiling is Thread based and assumes that the life of a query belongs to a single thread. We can fix this problem by per request metrics : https://our.intern.facebook.com/intern/wiki/index.php/HBase/InternProjects/HBasePerRequestMetrics.
Test Plan: Ensure TestHeaderSendRecieve works fine.
Reviewers: gauravm, adela
Reviewed By: adela
Subscribers: hbase-eng@
Differential Revision: https://phabricator.fb.com/D1402977
Tasks: 4584691
git-svn-id: svn+ssh://tubbs/svnhive/hadoop/branches/titan/VENDOR.hbase/hbase-trunk@43154 e7acf4d4-3532-417f-9e73-7a9ae25a1f51
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/5ff5311d
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/5ff5311d
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/5ff5311d
Branch: refs/heads/0.89-fb
Commit: 5ff5311da2ea970552f7e020aae7a5fe6674343e
Parents: abbf77d
Author: manukranthk <ma...@e7acf4d4-3532-417f-9e73-7a9ae25a1f51>
Authored: Wed Jun 25 20:32:30 2014 +0000
Committer: Elliott Clark <el...@fb.com>
Committed: Thu Jul 31 14:44:23 2014 -0700
----------------------------------------------------------------------
.../org/apache/hadoop/hbase/thrift/TestHeaderSendReceive.java | 4 ----
1 file changed, 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/5ff5311d/src/test/java/org/apache/hadoop/hbase/thrift/TestHeaderSendReceive.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/hadoop/hbase/thrift/TestHeaderSendReceive.java b/src/test/java/org/apache/hadoop/hbase/thrift/TestHeaderSendReceive.java
index 61e3521..00d1454 100644
--- a/src/test/java/org/apache/hadoop/hbase/thrift/TestHeaderSendReceive.java
+++ b/src/test/java/org/apache/hadoop/hbase/thrift/TestHeaderSendReceive.java
@@ -161,10 +161,6 @@ public class TestHeaderSendReceive {
Assert.assertTrue(ProfilingData.TOTAL_SERVER_TIME_MS
+ " should be greater than zero",
pd.getLong(ProfilingData.TOTAL_SERVER_TIME_MS).longValue() >= 0L);
- if (isPut) {
- assertNotNull(ProfilingData.HLOG_SYNC_TIME_MS + " is null",
- pd.getLong(ProfilingData.HLOG_SYNC_TIME_MS));
- }
}
/**