You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2023/12/08 07:36:51 UTC
[PR] [SPARK-46326][PYTHON][TESTS] Test missing cases for functions (pyspark.sql.functions) [spark]
HyukjinKwon opened a new pull request, #44256:
URL: https://github.com/apache/spark/pull/44256
### What changes were proposed in this pull request?
This PR proposes to improve test coverage by adding the tests for full test coverage in `pyspark.sql.functions`. In addition, this PR improves the examples by adding doctests a little bit.
### Why are the changes needed?
For better test coverage, to avoid regressions.
They are not being tested: https://app.codecov.io/gh/apache/spark/blob/master/python%2Fpyspark%2Fsql%2Fsession.py
### Does this PR introduce _any_ user-facing change?
It contains a bit of docstring improvement. Otherwise, test-only.
### How was this patch tested?
Manually tested the unittests via:
```bash
./python/run-tests --python-executables=python3 --testnames 'pyspark.sql.tests.connect.test_parity_functions'
./python/run-tests --python-executables=python3 --testnames 'pyspark.sql.tests.test_functions'
./python/run-tests --python-executables=python3 --testnames 'pyspark.sql.functions.builtin'
```
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46326][PYTHON][TESTS] Test missing cases for functions (pyspark.sql.functions) [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #44256:
URL: https://github.com/apache/spark/pull/44256#issuecomment-1847047417
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46326][PYTHON][TESTS] Test missing cases for functions (pyspark.sql.functions) [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #44256: [SPARK-46326][PYTHON][TESTS] Test missing cases for functions (pyspark.sql.functions)
URL: https://github.com/apache/spark/pull/44256
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org