[jira] [Commented] (ARTEMIS-5139) Remove locking on TypedProperties getters

["Justin Bertram (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARTEMIS-5139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894925#comment-17894925 ] 

Justin Bertram commented on ARTEMIS-5139:
-----------------------------------------

I'm having a hard time interpreting that screen shot. Generally speaking I wouldn't expect much contention here. Are you that's really the issue and not the allocation of a new {{HashSet}}?

> Remove locking on TypedProperties getters
> -----------------------------------------
>
>                 Key: ARTEMIS-5139
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-5139
>             Project: ActiveMQ Artemis
>          Issue Type: Task
>            Reporter: Josh Byster
>            Priority: Minor
>         Attachments: Screenshot 2024-10-30 at 10.38.54 PM.png
>
>
> We are noticing a performance degradation when switching to Artemis in places where we are sensitive on the millisecond level. We have confirmed that moving to ZGC and having minimal GC pause times cannot explain this spike. Looking at a flight recording, it does appear we are spending a lot of time blocked on TypedProperties getters (see screenshot). It seems like we can probably remove some of the locking here with a concurrent collection or be smarter about it with a ReadWriteLock, given that it appears we have threads competing for read calls.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@activemq.apache.org
For additional commands, e-mail: issues-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact