cvs commit: httpd-test/flood CHANGES flood_socket_generic.c

[je...@apache.org]

jerenkrantz    2003/02/12 14:44:55

  Modified:    flood    CHANGES flood_socket_generic.c
  Log:
  Fixed compiler warning about signed/unsigned mismatch in generic_recv_resp()
  
  This patch addresses the following compiler warning generated by the
  Visual C++ 6 compiler:
  
  flood_socket_generic.c(161) : warning C4018: '>' : signed/unsigned mismatch
  
  We have two local variables declared as integers used in an expression
  involving an unsigned type.  I changed the variable declarations to
  match the unsigned type to address the warning.  All three variables
  involved deal with memory sizes using apr_size_t, so it's safe to
  change the declarations.
  
  Submitted by: Phi-Long Tran <pt...@pobox.com>
  Reviewed by: Justin Erenkrantz
  
  Revision  Changes    Path
  1.46      +3 -0      httpd-test/flood/CHANGES
  
  Index: CHANGES
  ===================================================================
  RCS file: /home/cvs/httpd-test/flood/CHANGES,v
  retrieving revision 1.45
  retrieving revision 1.46
  diff -u -u -r1.45 -r1.46
  --- CHANGES	29 Jan 2003 06:19:20 -0000	1.45
  +++ CHANGES	12 Feb 2003 22:44:55 -0000	1.46
  @@ -1,5 +1,8 @@
   Changes since 1.0:
   
  +* Fixed compiler warning about signed/unsigned mismatch in generic_recv_resp.
  +  [Phi-Long Tran <pt...@pobox.com>]
  +
   * Include correct header to import defintion of apr_pstrmemdup in
     flood_socket_keepalive.c.  [Phi-Long Tran <pt...@pobox.com>]
   
  
  
  
  1.9       +2 -2      httpd-test/flood/flood_socket_generic.c
  
  Index: flood_socket_generic.c
  ===================================================================
  RCS file: /home/cvs/httpd-test/flood/flood_socket_generic.c,v
  retrieving revision 1.8
  retrieving revision 1.9
  diff -u -u -r1.8 -r1.9
  --- flood_socket_generic.c	3 Feb 2003 17:10:56 -0000	1.8
  +++ flood_socket_generic.c	12 Feb 2003 22:44:55 -0000	1.9
  @@ -134,7 +134,7 @@
   apr_status_t generic_recv_resp(response_t **resp, socket_t *sock, apr_pool_t *pool)
   {
       char b[MAX_DOC_LENGTH];
  -    int i;
  +    apr_size_t i;
       response_t *new_resp;
       apr_status_t status;
   
  @@ -146,7 +146,7 @@
       if (gsock->wantresponse)
       {
           /* Ugh, we want everything. */
  -        int currentalloc;
  +        apr_size_t currentalloc;
           char *cp, *op;
   
           new_resp->rbufsize = 0;