You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/02/04 14:17:34 UTC
[GitHub] [netbeans] entlicher opened a new pull request #2730: Always do save modified files when used through LSP.
entlicher opened a new pull request #2730:
URL: https://github.com/apache/netbeans/pull/2730
As described in NETBEANS-5319, when new files are added through LSP (e.g. in a VSCode extension), breakpoints do not work in these files at all.
If a file is modified, then breakpoints are submitted to wrong locations depending on the scope of the modification.
The reason is that NetBeans LSP backend is holding modified documents and VSCode updates files on disk at the same time. But breakpoints are resolved to disk locations that correspond to the sate before the files were modified. Until the files are saved through the NetBeans, breakpoints will resolve to wrong locations.
This fix allows to save modifications it got through the LSP protocol, which synchronizes the content and allows breakpoints to resolve as expected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] entlicher commented on pull request #2730: Always do save modified files when used through LSP.
Posted by GitBox <gi...@apache.org>.
entlicher commented on pull request #2730:
URL: https://github.com/apache/netbeans/pull/2730#issuecomment-773350204
A very small change and in the LSP code only.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] entlicher commented on pull request #2730: Always do save modified files when used through LSP.
Posted by GitBox <gi...@apache.org>.
entlicher commented on pull request #2730:
URL: https://github.com/apache/netbeans/pull/2730#issuecomment-773350204
A very small change and in the LSP code only.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] geertjanw merged pull request #2730: [NETBEANS-5319] Always do save modified files when used through LSP.
Posted by GitBox <gi...@apache.org>.
geertjanw merged pull request #2730:
URL: https://github.com/apache/netbeans/pull/2730
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists