You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/23 22:09:47 UTC

[GitHub] [incubator-superset] eschutho opened a new pull request #12198: feat: sql lab toolbar fixes

eschutho opened a new pull request #12198:
URL: https://github.com/apache/incubator-superset/pull/12198


   ### SUMMARY
   Fixes a few styling/interaction issues with sql lab toolbar:
   DONE: Buttons aren't centered vertically in the container (currently too far down)
   DONE: Tooltip on Run button currently shows up when hovering over CTAS and CVAS options
   DONE Limit currently uses both commas and spaces - we should just use spaces
   DONE overflow menu: style overflow dropdown menu to match run and limit dropdowns (no caret)
   DONE overflow menu & dropdown buttons (run & limit): trigger dropdown on click instead of hover
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   
   https://user-images.githubusercontent.com/5186919/103040404-2e233600-4528-11eb-8acb-fc32a5675545.mov
   
   
   https://user-images.githubusercontent.com/5186919/103040481-662a7900-4528-11eb-861f-f0823cfe6717.mov
   
   
   
   
   ### TEST PLAN
   existing jest tests should pass
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io commented on pull request #12198: feat: sql lab toolbar fixes

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12198:
URL: https://github.com/apache/incubator-superset/pull/12198#issuecomment-750495759


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12198?src=pr&el=h1) Report
   > Merging [#12198](https://codecov.io/gh/apache/incubator-superset/pull/12198?src=pr&el=desc) (2fa872c) into [feat-sql-toolbar](https://codecov.io/gh/apache/incubator-superset/commit/0e64ceb2ad710a2906a65a0e6dfe63fe93b76d57?el=desc) (0e64ceb) will **increase** coverage by `0.33%`.
   > The diff coverage is `74.65%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12198/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12198?src=pr&el=tree)
   
   ```diff
   @@                 Coverage Diff                  @@
   ##           feat-sql-toolbar   #12198      +/-   ##
   ====================================================
   + Coverage             63.27%   63.61%   +0.33%     
   ====================================================
     Files                   971      484     -487     
     Lines                 48118    29749   -18369     
     Branches               4794        0    -4794     
   ====================================================
   - Hits                  30446    18924   -11522     
   + Misses                17479    10825    -6654     
   + Partials                193        0     -193     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `?` | |
   | python | `63.61% <74.65%> (-0.60%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12198?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/datasets/commands/importers/v1/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/12198/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL3V0aWxzLnB5) | `58.62% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/12198/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/12198/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | |
   | [superset/reports/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12198/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9hcGkucHk=) | `85.48% <ø> (ø)` | |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/12198/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/12198/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/12198/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.30% <35.71%> (-2.29%)` | :arrow_down: |
   | [superset/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/12198/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `94.73% <50.00%> (-1.21%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12198/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <50.00%> (-11.85%)` | :arrow_down: |
   | [superset/examples/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/12198/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvdXRpbHMucHk=) | `33.33% <50.00%> (+1.75%)` | :arrow_up: |
   | ... and [470 more](https://codecov.io/gh/apache/incubator-superset/pull/12198/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12198?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12198?src=pr&el=footer). Last update [0e64ceb...2fa872c](https://codecov.io/gh/apache/incubator-superset/pull/12198?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12198: feat: sql lab toolbar fixes

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12198:
URL: https://github.com/apache/incubator-superset/pull/12198#issuecomment-750495759


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12198?src=pr&el=h1) Report
   > Merging [#12198](https://codecov.io/gh/apache/incubator-superset/pull/12198?src=pr&el=desc) (2fa872c) into [feat-sql-toolbar](https://codecov.io/gh/apache/incubator-superset/commit/0e64ceb2ad710a2906a65a0e6dfe63fe93b76d57?el=desc) (0e64ceb) will **increase** coverage by `0.37%`.
   > The diff coverage is `74.65%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12198/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12198?src=pr&el=tree)
   
   ```diff
   @@                 Coverage Diff                  @@
   ##           feat-sql-toolbar   #12198      +/-   ##
   ====================================================
   + Coverage             63.27%   63.64%   +0.37%     
   ====================================================
     Files                   971      484     -487     
     Lines                 48118    29749   -18369     
     Branches               4794        0    -4794     
   ====================================================
   - Hits                  30446    18935   -11511     
   + Misses                17479    10814    -6665     
   + Partials                193        0     -193     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `?` | |
   | python | `63.64% <74.65%> (-0.56%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12198?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/datasets/commands/importers/v1/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/12198/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL3V0aWxzLnB5) | `58.62% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/12198/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/12198/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | |
   | [superset/reports/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12198/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9hcGkucHk=) | `85.48% <ø> (ø)` | |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/12198/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/12198/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/12198/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `86.08% <35.71%> (-1.52%)` | :arrow_down: |
   | [superset/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/12198/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `94.73% <50.00%> (-1.21%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12198/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <50.00%> (-11.85%)` | :arrow_down: |
   | [superset/examples/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/12198/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvdXRpbHMucHk=) | `33.33% <50.00%> (+1.75%)` | :arrow_up: |
   | ... and [466 more](https://codecov.io/gh/apache/incubator-superset/pull/12198/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12198?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12198?src=pr&el=footer). Last update [0e64ceb...2fa872c](https://codecov.io/gh/apache/incubator-superset/pull/12198?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12198: feat: sql lab toolbar fixes

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12198:
URL: https://github.com/apache/incubator-superset/pull/12198#issuecomment-750495759


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12198?src=pr&el=h1) Report
   > Merging [#12198](https://codecov.io/gh/apache/incubator-superset/pull/12198?src=pr&el=desc) (2fa872c) into [feat-sql-toolbar](https://codecov.io/gh/apache/incubator-superset/commit/0e64ceb2ad710a2906a65a0e6dfe63fe93b76d57?el=desc) (0e64ceb) will **increase** coverage by `0.98%`.
   > The diff coverage is `75.34%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12198/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12198?src=pr&el=tree)
   
   ```diff
   @@                 Coverage Diff                  @@
   ##           feat-sql-toolbar   #12198      +/-   ##
   ====================================================
   + Coverage             63.27%   64.26%   +0.98%     
   ====================================================
     Files                   971      484     -487     
     Lines                 48118    29764   -18354     
     Branches               4794        0    -4794     
   ====================================================
   - Hits                  30446    19127   -11319     
   + Misses                17479    10637    -6842     
   + Partials                193        0     -193     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `?` | |
   | python | `64.26% <75.34%> (+0.05%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12198?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/datasets/commands/importers/v1/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/12198/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL3V0aWxzLnB5) | `58.62% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/12198/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/12198/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | |
   | [superset/reports/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12198/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9hcGkucHk=) | `85.48% <ø> (ø)` | |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/12198/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/12198/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/12198/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `86.08% <35.71%> (-1.52%)` | :arrow_down: |
   | [superset/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/12198/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `94.73% <50.00%> (-1.21%)` | :arrow_down: |
   | [superset/examples/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/12198/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvdXRpbHMucHk=) | `33.33% <50.00%> (+1.75%)` | :arrow_up: |
   | [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12198/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `85.96% <52.94%> (-14.04%)` | :arrow_down: |
   | ... and [449 more](https://codecov.io/gh/apache/incubator-superset/pull/12198/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12198?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12198?src=pr&el=footer). Last update [0e64ceb...2fa872c](https://codecov.io/gh/apache/incubator-superset/pull/12198?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12198: feat: sql lab toolbar fixes

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12198:
URL: https://github.com/apache/incubator-superset/pull/12198#issuecomment-750495759






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12198: feat: sql lab toolbar fixes

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12198:
URL: https://github.com/apache/incubator-superset/pull/12198#issuecomment-750495759


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12198?src=pr&el=h1) Report
   > Merging [#12198](https://codecov.io/gh/apache/incubator-superset/pull/12198?src=pr&el=desc) (2fa872c) into [feat-sql-toolbar](https://codecov.io/gh/apache/incubator-superset/commit/0e64ceb2ad710a2906a65a0e6dfe63fe93b76d57?el=desc) (0e64ceb) will **increase** coverage by `0.83%`.
   > The diff coverage is `75.34%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12198/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12198?src=pr&el=tree)
   
   ```diff
   @@                 Coverage Diff                  @@
   ##           feat-sql-toolbar   #12198      +/-   ##
   ====================================================
   + Coverage             63.27%   64.10%   +0.83%     
   ====================================================
     Files                   971      484     -487     
     Lines                 48118    29764   -18354     
     Branches               4794        0    -4794     
   ====================================================
   - Hits                  30446    19080   -11366     
   + Misses                17479    10684    -6795     
   + Partials                193        0     -193     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `?` | |
   | python | `64.10% <75.34%> (-0.11%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12198?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/datasets/commands/importers/v1/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/12198/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL3V0aWxzLnB5) | `58.62% <ø> (ø)` | |
   | [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/12198/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/12198/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | |
   | [superset/reports/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12198/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9hcGkucHk=) | `85.48% <ø> (ø)` | |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/12198/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/12198/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/12198/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `86.08% <35.71%> (-1.52%)` | :arrow_down: |
   | [superset/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/12198/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `94.73% <50.00%> (-1.21%)` | :arrow_down: |
   | [superset/examples/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/12198/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvdXRpbHMucHk=) | `33.33% <50.00%> (+1.75%)` | :arrow_up: |
   | [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12198/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `85.96% <52.94%> (-14.04%)` | :arrow_down: |
   | ... and [455 more](https://codecov.io/gh/apache/incubator-superset/pull/12198/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12198?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12198?src=pr&el=footer). Last update [0e64ceb...2fa872c](https://codecov.io/gh/apache/incubator-superset/pull/12198?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] hughhhh merged pull request #12198: feat: sql lab toolbar fixes

Posted by GitBox <gi...@apache.org>.
hughhhh merged pull request #12198:
URL: https://github.com/apache/incubator-superset/pull/12198


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org