You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@activemq.apache.org by cl...@apache.org on 2020/12/21 21:21:50 UTC

[activemq-artemis] branch master updated: NO-JIRA Fixing intermittent test failure

This is an automated email from the ASF dual-hosted git repository.

clebertsuconic pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/activemq-artemis.git


The following commit(s) were added to refs/heads/master by this push:
     new c3beea3  NO-JIRA Fixing intermittent test failure
c3beea3 is described below

commit c3beea3a9e972079bf4a298a75adb675d72e3c0c
Author: Clebert Suconic <cl...@apache.org>
AuthorDate: Mon Dec 21 16:19:38 2020 -0500

    NO-JIRA Fixing intermittent test failure
    
    waiting advisory to update client on openwire client
---
 .../integration/openwire/cluster/OpenWireJMSClusteredTestBase.java    | 4 ++--
 .../tests/integration/openwire/cluster/TemporaryQueueClusterTest.java | 4 ++++
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/cluster/OpenWireJMSClusteredTestBase.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/cluster/OpenWireJMSClusteredTestBase.java
index 66aca80..44d731f 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/cluster/OpenWireJMSClusteredTestBase.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/cluster/OpenWireJMSClusteredTestBase.java
@@ -32,8 +32,8 @@ public class OpenWireJMSClusteredTestBase extends ClusterTestBase {
    public void setUp() throws Exception {
       super.setUp();
 
-      setupServer(0, true, true);
-      setupServer(1, true, true);
+      setupServer(0, isFileStorage(), true);
+      setupServer(1, isFileStorage(), true);
 
       setupClusterConnection("cluster0", "", MessageLoadBalancingType.ON_DEMAND, 1, true, 0, 1);
       setupClusterConnection("cluster1", "", MessageLoadBalancingType.ON_DEMAND, 1, true, 1, 0);
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/cluster/TemporaryQueueClusterTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/cluster/TemporaryQueueClusterTest.java
index cc818bb..2e55664 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/cluster/TemporaryQueueClusterTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/cluster/TemporaryQueueClusterTest.java
@@ -16,6 +16,7 @@
  */
 package org.apache.activemq.artemis.tests.integration.openwire.cluster;
 
+import org.apache.activemq.ActiveMQConnection;
 import org.apache.activemq.artemis.api.core.RoutingType;
 import org.apache.activemq.artemis.api.core.SimpleString;
 import org.apache.activemq.artemis.utils.Wait;
@@ -130,6 +131,9 @@ public class TemporaryQueueClusterTest extends OpenWireJMSClusteredTestBase {
             prod1.send(message);
          }
 
+         // waiting the advisory to update the activeTempDestinations
+         Wait.assertTrue(() -> ((ActiveMQConnection) conn2).activeTempDestinations.containsValue(tempQueue));
+
          for (int i = 0; i < 10; i++) {
             if (i % 2 == 0) {
                TextMessage received = (TextMessage) cons2.receive(5000);