You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucy.apache.org by rectang <gi...@git.apache.org> on 2016/03/30 06:10:59 UTC
[lucy-dev] [GitHub] lucy pull request: LUCY-295 Adapt for changed return type of Vec_G...
GitHub user rectang opened a pull request:
https://github.com/apache/lucy/pull/36
LUCY-295 Adapt for changed return type of Vec_Get_Size
The Clownfish API `Vec_Get_Size` has changed from returning `uint32_t` to returning `size_t`. Adapt Lucy for the effect of this change.
This branch is broken up into commits according to the kind of remedy that was applied at each site, and the associated difficulty of proofing the change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rectang/lucy LUCY-295-vec-size
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucy/pull/36.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #36
----
commit e2235fef95d2a1253ccba8405518e67a3445a99e
Author: Marvin Humphrey <ma...@rectangular.com>
Date: 2016-03-29T23:12:17Z
Iter var change to match Vec_Get_Size.
Change the type of iteration variables to `size_t` to match the return
type of Vec_Get_Size. This commit is restricted to simple cases where
the iteration variable is scoped to the loop block and is only used as
an C array index or arguments to Vector methods which take a `size_t`.
commit f0884c6ac873f65432a1f92e4c475ff488db21cb
Author: Marvin Humphrey <ma...@rectangular.com>
Date: 2016-03-30T01:59:11Z
Type change to match Vec_Get_Size.
Widen the types of variables which are assigned the return value from
Vec_Get_Size. The widening should have no impact on behavior or require
any casting; the variables should not be used in any context which
requires implicit conversion.
commit e7d675a67fefcca764d538b5dafc76d57ed42c47
Author: Marvin Humphrey <ma...@rectangular.com>
Date: 2016-03-30T03:10:23Z
Tricky type changes to match Vec_Get_Size.
After converting variables assigned the return value of Vec_Get_Size
from `uint32_t` to `size_t`, at least one cast or other type conversion
is performed.
commit 10c57752ee1a2f45d3f6d7e372bd9c9279f9e98c
Author: Marvin Humphrey <ma...@rectangular.com>
Date: 2016-03-30T04:02:45Z
Fix sign of arg to sizeof.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[lucy-dev] [GitHub] lucy pull request: LUCY-295 Adapt for changed return type of Vec_G...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/lucy/pull/36
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---