Pluto 2.0 tests portlets don't run in Tomcat 6.0.17+

[Matias Alberto Gavinowich <ma...@gmail.com>]

Hi everyone,

This is to let you know that I found an issue which prevents the test
portlets bundled with Pluto (trunk, as of 20081101 which is when I
checked it out) to run on Tomcat versions higher than 6.0.16. As I
think I know the cause I am sending the email directly to the
developers list.

A recent fix in Tomcat, described at
https://issues.apache.org/bugzilla/show_bug.cgi?id=45015 has tightened
some restrictions on jsp tags to better conform to the JSP spec. If a
malformed jsp tag is used an error similar to the following is
obtained:

SEVERE: org.apache.jasper.JasperException: /jsp/test_results.jsp(25,0)
/jsp/navigation.inc(35,38) Attribute value  request.isSecure() ?
"True" : "False"  is quoted with " which must be escaped when used
within the value
javax.portlet.PortletException: org.apache.jasper.JasperException:
/jsp/test_results.jsp(25,0) /jsp/navigation.inc(35,38) Attribute value
 request.isSecure() ? "True" : "False"  is quoted with " which must be
escaped when used within the value

I guess some pages in the test portlets contain tags with attribute
values which are not properly escaped when using quotes. I don't know
which pages exactly, I could not get around to investigate that.
I have noticed Pluto has been tested with Tomcat 6.0.13, I have tested
it with Tomcat 6.0.18 and downgraded to 6.0.16 when I got this
message, which solved my problem. The bugzilla entry I linked above
states the fix has been introduced in Tomcat 5.5.27 and Tomcat 6.0.17
onwards (though I found no 6.0.17, I just used 6.0.18).

Regards,

Matt

PS: I did not want to create a JIRA on this before asking...

Re: Pluto 2.0 tests portlets don't run in Tomcat 6.0.17+

[Ate Douma <at...@douma.nu>]

Matias Alberto Gavinowich wrote:
> Hi everyone,
> 
> This is to let you know that I found an issue which prevents the test
> portlets bundled with Pluto (trunk, as of 20081101 which is when I
> checked it out) to run on Tomcat versions higher than 6.0.16. As I
> think I know the cause I am sending the email directly to the
> developers list.
Thanks for doing so Matias!

> 
> A recent fix in Tomcat, described at
> https://issues.apache.org/bugzilla/show_bug.cgi?id=45015 has tightened
> some restrictions on jsp tags to better conform to the JSP spec. If a
> malformed jsp tag is used an error similar to the following is
> obtained:
> 
> SEVERE: org.apache.jasper.JasperException: /jsp/test_results.jsp(25,0)
> /jsp/navigation.inc(35,38) Attribute value  request.isSecure() ?
> "True" : "False"  is quoted with " which must be escaped when used
> within the value
> javax.portlet.PortletException: org.apache.jasper.JasperException:
> /jsp/test_results.jsp(25,0) /jsp/navigation.inc(35,38) Attribute value
>  request.isSecure() ? "True" : "False"  is quoted with " which must be
> escaped when used within the value
> 
> I guess some pages in the test portlets contain tags with attribute
> values which are not properly escaped when using quotes. I don't know
> which pages exactly, I could not get around to investigate that.
This issue I encountered myself too while working on the 2.0-spi-refactoring branch with Tomcat 5.5.27, which as you report further down, 
indeed has the same added restrictions on JSP tags.
For the Pluto 2.0-spi-refactoring branch, these issues have been resolved already (adjusting the attribute definition).

As you might have noticed on this list, last Friday I send out a VOTE to replace the current Pluto trunk with the 2.0-spi-refactoring 
branch. Once that is accepted and applied, this issue automatically will be fixed for the trunk then.

If you want you evaluate the 2.0-spi-refactoring branch as its stable and buildable just as the current trunk.
The branch has largely reduced its shared (library) dependencies and now you will only need (and be provided with):

   ccpp-1.0.jar
   pluto-container-api-2.0.0-SNAPSHOT.jar
   pluto-taglib-2.0.0-SNAPSHOT.jar
   portlet-api-2.0.jar

So, make sure to clean out the "old" shared libraries first from a previous Pluto trunk installation, as keeping the old shared dependencies 
around will actually break it.

Regards,

Ate

> I have noticed Pluto has been tested with Tomcat 6.0.13, I have tested
> it with Tomcat 6.0.18 and downgraded to 6.0.16 when I got this
> message, which solved my problem. The bugzilla entry I linked above
> states the fix has been introduced in Tomcat 5.5.27 and Tomcat 6.0.17
> onwards (though I found no 6.0.17, I just used 6.0.18).
> 
> Regards,
> 
> Matt
> 
> PS: I did not want to create a JIRA on this before asking...
>