You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by Kristen Legacy <kr...@gmail.com> on 2012/07/18 18:25:56 UTC
Review Request: RAVE-539: widget store detail display (detail & store pages)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6031/
-----------------------------------------------------------
Review request for rave.
Description
-------
Improved on style & layout of store and details pages (which now use the same style rules for the majority of elements).
Diffs
-----
trunk/rave-portal-resources/src/main/resources/messages.properties 1362964
trunk/rave-portal-resources/src/main/resources/messages_es.properties 1362964
trunk/rave-portal-resources/src/main/resources/messages_nl.properties 1362964
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp 1362964
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/widget.jsp 1362964
trunk/rave-portal-resources/src/main/webapp/static/css/rave-css.less 1362964
trunk/rave-portal-resources/src/main/webapp/static/script/rave_store.js 1362964
Diff: https://reviews.apache.org/r/6031/diff/
Testing
-------
Thanks,
Kristen Legacy
Re: Review Request: RAVE-539: widget store detail display (detail &
store pages)
Posted by "Franklin, Matthew B." <mf...@mitre.org>.
On 10/5/12 4:53 AM, "Jasha Joachimsthal" <ja...@apache.org> wrote:
>I noticed similar pieces of jsp in the store, w3c store and marketplace
>when fixing RAVE-804.. Time for a JSP tag?
+1. In general, I think we need to start splitting up the UI in to
smaller pieces so changes can be more easily made by implementers without
forcing them to copy entire JSPs down.
>
>On 5 October 2012 09:24, Scott Wilson
><sc...@gmail.com>wrote:
>
>> Hi Kristen,
>>
>> addwidget_marketplace.jsp is also based on store.jsp so may be worth
>>also
>> bringing in line with the style changes.
>>
>> S
>>
>> On 4 Oct 2012, at 20:23, Kristen Legacy wrote:
>>
>> >
>> > -----------------------------------------------------------
>> > This is an automatically generated e-mail. To reply, visit:
>> > https://reviews.apache.org/r/6031/
>> > -----------------------------------------------------------
>> >
>> > (Updated Oct. 4, 2012, 7:23 p.m.)
>> >
>> >
>> > Review request for rave.
>> >
>> >
>> > Changes
>> > -------
>> >
>> > Trigger happy today. Removed " in choose.
>> >
>> >
>> > Description
>> > -------
>> >
>> > Improved on style & layout of store and details pages (which now use
>>the
>> same style rules for the majority of elements).
>> >
>> >
>> > Diffs (updated)
>> > -----
>> >
>> > trunk/rave-portal-resources/src/main/resources/messages.properties
>> 1394204
>> > trunk/rave-portal-resources/src/main/resources/messages_es.properties
>> 1394204
>> > trunk/rave-portal-resources/src/main/resources/messages_nl.properties
>> 1394204
>> >
>>trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp
>> 1394204
>> >
>>
>>trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/widget.jsp
>> 1394204
>> > trunk/rave-portal-resources/src/main/webapp/static/css/rave-css.less
>> 1394204
>> >
>>trunk/rave-portal-resources/src/main/webapp/static/script/rave_store.js
>> 1394204
>> >
>> > Diff: https://reviews.apache.org/r/6031/diff/
>> >
>> >
>> > Testing
>> > -------
>> >
>> >
>> > Thanks,
>> >
>> > Kristen Legacy
>> >
>>
>>
Re: Review Request: RAVE-539: widget store detail display (detail &
store pages)
Posted by Jasha Joachimsthal <ja...@apache.org>.
I noticed similar pieces of jsp in the store, w3c store and marketplace
when fixing RAVE-804.. Time for a JSP tag?
On 5 October 2012 09:24, Scott Wilson <sc...@gmail.com>wrote:
> Hi Kristen,
>
> addwidget_marketplace.jsp is also based on store.jsp so may be worth also
> bringing in line with the style changes.
>
> S
>
> On 4 Oct 2012, at 20:23, Kristen Legacy wrote:
>
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/6031/
> > -----------------------------------------------------------
> >
> > (Updated Oct. 4, 2012, 7:23 p.m.)
> >
> >
> > Review request for rave.
> >
> >
> > Changes
> > -------
> >
> > Trigger happy today. Removed " in choose.
> >
> >
> > Description
> > -------
> >
> > Improved on style & layout of store and details pages (which now use the
> same style rules for the majority of elements).
> >
> >
> > Diffs (updated)
> > -----
> >
> > trunk/rave-portal-resources/src/main/resources/messages.properties
> 1394204
> > trunk/rave-portal-resources/src/main/resources/messages_es.properties
> 1394204
> > trunk/rave-portal-resources/src/main/resources/messages_nl.properties
> 1394204
> > trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp
> 1394204
> >
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/widget.jsp
> 1394204
> > trunk/rave-portal-resources/src/main/webapp/static/css/rave-css.less
> 1394204
> > trunk/rave-portal-resources/src/main/webapp/static/script/rave_store.js
> 1394204
> >
> > Diff: https://reviews.apache.org/r/6031/diff/
> >
> >
> > Testing
> > -------
> >
> >
> > Thanks,
> >
> > Kristen Legacy
> >
>
>
Re: Review Request: RAVE-539: widget store detail display (detail & store pages)
Posted by Scott Wilson <sc...@gmail.com>.
Hi Kristen,
addwidget_marketplace.jsp is also based on store.jsp so may be worth also bringing in line with the style changes.
S
On 4 Oct 2012, at 20:23, Kristen Legacy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6031/
> -----------------------------------------------------------
>
> (Updated Oct. 4, 2012, 7:23 p.m.)
>
>
> Review request for rave.
>
>
> Changes
> -------
>
> Trigger happy today. Removed " in choose.
>
>
> Description
> -------
>
> Improved on style & layout of store and details pages (which now use the same style rules for the majority of elements).
>
>
> Diffs (updated)
> -----
>
> trunk/rave-portal-resources/src/main/resources/messages.properties 1394204
> trunk/rave-portal-resources/src/main/resources/messages_es.properties 1394204
> trunk/rave-portal-resources/src/main/resources/messages_nl.properties 1394204
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp 1394204
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/widget.jsp 1394204
> trunk/rave-portal-resources/src/main/webapp/static/css/rave-css.less 1394204
> trunk/rave-portal-resources/src/main/webapp/static/script/rave_store.js 1394204
>
> Diff: https://reviews.apache.org/r/6031/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kristen Legacy
>
Re: Review Request: RAVE-539: widget store detail display (detail & store
pages)
Posted by Kristen Legacy <kr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6031/
-----------------------------------------------------------
(Updated Oct. 4, 2012, 7:23 p.m.)
Review request for rave.
Changes
-------
Trigger happy today. Removed " in choose.
Description
-------
Improved on style & layout of store and details pages (which now use the same style rules for the majority of elements).
Diffs (updated)
-----
trunk/rave-portal-resources/src/main/resources/messages.properties 1394204
trunk/rave-portal-resources/src/main/resources/messages_es.properties 1394204
trunk/rave-portal-resources/src/main/resources/messages_nl.properties 1394204
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp 1394204
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/widget.jsp 1394204
trunk/rave-portal-resources/src/main/webapp/static/css/rave-css.less 1394204
trunk/rave-portal-resources/src/main/webapp/static/script/rave_store.js 1394204
Diff: https://reviews.apache.org/r/6031/diff/
Testing
-------
Thanks,
Kristen Legacy
Re: Review Request: RAVE-539: widget store detail display (detail & store
pages)
Posted by Kristen Legacy <kr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6031/
-----------------------------------------------------------
(Updated Oct. 4, 2012, 7:13 p.m.)
Review request for rave.
Changes
-------
Swapped if to choose & updated the rest to most recent revision.
Description
-------
Improved on style & layout of store and details pages (which now use the same style rules for the majority of elements).
Diffs (updated)
-----
trunk/rave-portal-resources/src/main/resources/messages.properties 1394204
trunk/rave-portal-resources/src/main/resources/messages_es.properties 1394204
trunk/rave-portal-resources/src/main/resources/messages_nl.properties 1394204
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp 1394204
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/widget.jsp 1394204
trunk/rave-portal-resources/src/main/webapp/static/css/rave-css.less 1394204
trunk/rave-portal-resources/src/main/webapp/static/script/rave_store.js 1394204
Diff: https://reviews.apache.org/r/6031/diff/
Testing
-------
Thanks,
Kristen Legacy
Re: Review Request: RAVE-539: widget store detail display (detail & store
pages)
Posted by Matt Franklin <mf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6031/#review9556
-----------------------------------------------------------
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/widget.jsp
<https://reviews.apache.org/r/6031/#comment20417>
Looks like this should be a choose
<c:choose>
<c:when test="${condition1}">
...
</c:when>
<c:when test="${condition2}">
...
</c:when>
<c:otherwise>
...
</c:otherwise>
</c:choose>
- Matt Franklin
On July 18, 2012, 4:25 p.m., Kristen Legacy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6031/
> -----------------------------------------------------------
>
> (Updated July 18, 2012, 4:25 p.m.)
>
>
> Review request for rave.
>
>
> Description
> -------
>
> Improved on style & layout of store and details pages (which now use the same style rules for the majority of elements).
>
>
> Diffs
> -----
>
> trunk/rave-portal-resources/src/main/resources/messages.properties 1362964
> trunk/rave-portal-resources/src/main/resources/messages_es.properties 1362964
> trunk/rave-portal-resources/src/main/resources/messages_nl.properties 1362964
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp 1362964
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/widget.jsp 1362964
> trunk/rave-portal-resources/src/main/webapp/static/css/rave-css.less 1362964
> trunk/rave-portal-resources/src/main/webapp/static/script/rave_store.js 1362964
>
> Diff: https://reviews.apache.org/r/6031/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kristen Legacy
>
>