You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@openjpa.apache.org by pp...@apache.org on 2013/08/16 20:25:23 UTC
svn commit: r1514833 -
/openjpa/trunk/openjpa-persistence/src/main/java/org/apache/openjpa/persistence/criteria/Joins.java
Author: ppoddar
Date: Fri Aug 16 18:25:23 2013
New Revision: 1514833
URL: http://svn.apache.org/r1514833
Log:
OPENJPA-2318: Left outer join is not generated because allowNull was not passed correctly
Modified:
openjpa/trunk/openjpa-persistence/src/main/java/org/apache/openjpa/persistence/criteria/Joins.java
Modified: openjpa/trunk/openjpa-persistence/src/main/java/org/apache/openjpa/persistence/criteria/Joins.java
URL: http://svn.apache.org/viewvc/openjpa/trunk/openjpa-persistence/src/main/java/org/apache/openjpa/persistence/criteria/Joins.java?rev=1514833&r1=1514832&r2=1514833&view=diff
==============================================================================
--- openjpa/trunk/openjpa-persistence/src/main/java/org/apache/openjpa/persistence/criteria/Joins.java (original)
+++ openjpa/trunk/openjpa-persistence/src/main/java/org/apache/openjpa/persistence/criteria/Joins.java Fri Aug 16 18:25:23 2013
@@ -197,17 +197,18 @@ abstract class Joins {
if (c.isRegistered(_parent)) {
Value var = c.getRegisteredVariable(_parent);
path = factory.newPath(var);
- } else
+ } else {
path = factory.newPath(subQ);
+ }
path.setMetaData(meta);
- path.get(_member.fmd, false);
+ path.get(_member.fmd, allowNull);
path.setSchemaAlias(c.getAlias(_parent));
}
} else if (c.isRegistered(_parent)) {
Value var = c.getRegisteredVariable(_parent);
path = factory.newPath(var);
path.setMetaData(meta);
- path.get(_member.fmd, false);
+ path.get(_member.fmd, allowNull);
} else
path = (org.apache.openjpa.kernel.exps.Path)toValue(factory, c);
@@ -409,14 +410,14 @@ abstract class Joins {
path = factory.newPath(subQ);
}
path.setMetaData(meta);
- path.get(_member.fmd, false);
+ path.get(_member.fmd, allowNull);
path.setSchemaAlias(c.getAlias(_parent));
}
} else if (c.isRegistered(_parent)) {
Value var = c.getRegisteredVariable(_parent);
path = factory.newPath(var);
path.setMetaData(meta);
- path.get(_member.fmd, false);
+ path.get(_member.fmd, allowNull);
} else {
path = (org.apache.openjpa.kernel.exps.Path)toValue(factory, c);
}