You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2022/10/18 23:16:01 UTC
[GitHub] [hadoop] goiri commented on a diff in pull request #5005: YARN-11342. [Federation] Refactor getNewApplication, submitApplication Use FederationActionRetry.
goiri commented on code in PR #5005:
URL: https://github.com/apache/hadoop/pull/5005#discussion_r998790943
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/federation/FederationStateStoreService.java:
##########
@@ -506,8 +506,9 @@ public boolean cleanUpFinishApplicationsWithRetries(ApplicationId appId, boolean
DeleteApplicationHomeSubClusterRequest.newInstance(appId);
// CleanUp Finish App.
- return ((FederationActionRetry<Boolean>) () -> invokeCleanUpFinishApp(appId, isQuery, request))
- .runWithRetries(cleanUpRetryCountNum, cleanUpRetrySleepTime);
+ return ((FederationActionRetry<Boolean>) (retry) ->
+ invokeCleanUpFinishApp(appId, isQuery, request))
+ .runWithRetries(cleanUpRetryCountNum, cleanUpRetrySleepTime);
Review Comment:
indentation looks incorrect.
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/Federation.md:
##########
@@ -270,6 +270,7 @@ Optional:
|`yarn.router.admin.address` | `0.0.0.0:8052` | Admin address at the router. |
|`yarn.router.webapp.https.address` | `0.0.0.0:8091` | Secure webapp address at the router. |
|`yarn.router.submit.retry` | `3` | The number of retries in the router before we give up. |
+|`yarn.router.submit.interval.time` | `10` | The interval between two retry, the default value is 10ms. |
Review Comment:
10ms?
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml:
##########
@@ -5047,4 +5047,13 @@
</description>
</property>
+ <property>
+ <name>yarn.router.submit.interval.time</name>
+ <value>10</value>
Review Comment:
10ms?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org