You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2019/03/14 23:57:25 UTC

Re: Review Request 70150: Replaced a constructor in `ResourceQuantities`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70150/
-----------------------------------------------------------

(Updated March 14, 2019, 4:57 p.m.)


Review request for mesos and Benjamin Mahler.


Changes
-------

Rebased.


Repository: mesos


Description
-------

The constructor constructs `ResourceQuantities`
from `google::protobuf::Map<std::string, Value::Scalar>`.
It replaces one of the current constructors that takes
in `OfferFilters::ResourceQuantities`.


Diffs (updated)
-----

  src/common/resource_quantities.hpp 31ce7b98a8256173d6ad26e2f095373a01d7baae 
  src/common/resource_quantities.cpp 1c8eec03580abf86df4ce947c517a74b0a8e09a7 
  src/master/allocator/mesos/hierarchical.cpp 7085c23eeb163854712391e24d902902b8aaf162 


Diff: https://reviews.apache.org/r/70150/diff/3/

Changes: https://reviews.apache.org/r/70150/diff/2-3/


Testing
-------

make check


Thanks,

Meng Zhu