You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by gi...@git.apache.org on 2017/08/28 17:43:36 UTC

[GitHub] reminisce commented on a change in pull request #7638: CSRNDArray from/to scipy csr_matrix; fix rand_shape_nd

reminisce commented on a change in pull request #7638: CSRNDArray from/to scipy csr_matrix; fix rand_shape_nd
URL: https://github.com/apache/incubator-mxnet/pull/7638#discussion_r135585187
 
 

 ##########
 File path: python/mxnet/ndarray/sparse.py
 ##########
 @@ -417,6 +423,19 @@ def data(self):
         """
         return self._data()
 
+    @indices.setter
 
 Review comment:
   Do we plan to support these setters in the future? Seems scipy does not provide these interfaces. It feels problematic to call an individual setter since this might introduce data inconsistency issue.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services