You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@struts.apache.org by "Maurizio Cucchiara (JIRA)" <ji...@apache.org> on 2013/06/12 12:28:20 UTC

[jira] [Commented] (WW-4102) ActionSupport.LOG should be private

    [ https://issues.apache.org/jira/browse/WW-4102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13681087#comment-13681087 ] 

Maurizio Cucchiara commented on WW-4102:
----------------------------------------

Nothing to reject about the issue.

[~lukaszlenart] it will break the backward compatibility, so 2.3.16 could not be the right version.
                
> ActionSupport.LOG should be private
> -----------------------------------
>
>                 Key: WW-4102
>                 URL: https://issues.apache.org/jira/browse/WW-4102
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Core Actions
>    Affects Versions: 2.3.14.3
>            Reporter: Marcin Kamionowski
>             Fix For: 2.3.16
>
>
> ActionSupport is base class for actions. Actions cannot (or at least shouldn't) use ActionSupport.LOG because localisation source of messages is much harder in this situation. When ActionSuport.LOG is protected, some programmers might accidentally use this instance (LOG is popular name for loggers).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira