You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/01 22:16:53 UTC
[GitHub] [airflow] ferruzzi opened a new pull request #21920: Dynamo to S3 Sample DAG and Docs
ferruzzi opened a new pull request #21920:
URL: https://github.com/apache/airflow/pull/21920
Adds a sample DAG and docs for the existing Dynamo to S3 Transfer operator.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a change in pull request #21920: Dynamo to S3 Sample DAG and Docs
Posted by GitBox <gi...@apache.org>.
eladkal commented on a change in pull request #21920:
URL: https://github.com/apache/airflow/pull/21920#discussion_r820213338
##########
File path: airflow/providers/amazon/aws/example_dags/example_dynamodb_to_s3.py
##########
@@ -0,0 +1,43 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+from datetime import datetime
+from os import environ
+
+from airflow import DAG
+from airflow.providers.amazon.aws.transfers.dynamodb_to_s3 import DynamoDBToS3Operator
+
+TABLE_NAME = environ.get('DYNAMO_TABLE_NAME', 'ExistingDynamoDbTableName')
+BUCKET_NAME = environ.get('S3_BUCKET_NAME', 'ExistingS3BucketName')
+
+
+with DAG(
+ dag_id='example_dynamodb_to_s3',
+ schedule_interval=None,
+ start_date=datetime(2021, 1, 1),
+ tags=['example'],
+ catchup=False,
+) as dag:
+
+ # [START howto_transfer_dynamodb_to_s3]
+ backup_db = DynamoDBToS3Operator(
+ task_id='backup_db',
+ dynamodb_table_name=TABLE_NAME,
+ s3_bucket_name=BUCKET_NAME,
+ # Max output file size in bytes. If the Table is too large, multiple files will be created.
+ file_size=1000,
Review comment:
Can you please extend the example/docs to include also the segment explanation?
https://github.com/apache/airflow/blob/602abe8394fafe7de54df7e73af56de848cdf617/airflow/providers/amazon/aws/transfers/dynamodb_to_s3.py#L65-L87
(and remove the segment example from the comments)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ferruzzi commented on pull request #21920: Dynamo to S3 Sample DAG and Docs
Posted by GitBox <gi...@apache.org>.
ferruzzi commented on pull request #21920:
URL: https://github.com/apache/airflow/pull/21920#issuecomment-1058381288
Failing image build; rebased
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ferruzzi closed pull request #21920: Dynamo to S3 Sample DAG and Docs
Posted by GitBox <gi...@apache.org>.
ferruzzi closed pull request #21920:
URL: https://github.com/apache/airflow/pull/21920
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #21920: Dynamo to S3 Sample DAG and Docs
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #21920:
URL: https://github.com/apache/airflow/pull/21920
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #21920: Dynamo to S3 Sample DAG and Docs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #21920:
URL: https://github.com/apache/airflow/pull/21920#issuecomment-1061649548
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ferruzzi commented on pull request #21920: Dynamo to S3 Sample DAG and Docs
Posted by GitBox <gi...@apache.org>.
ferruzzi commented on pull request #21920:
URL: https://github.com/apache/airflow/pull/21920#issuecomment-1057552090
@eladkal - Another short one in the DAG/Docs improvement project if you get time, since you reviewed the previous ones.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ferruzzi commented on a change in pull request #21920: Dynamo to S3 Sample DAG and Docs
Posted by GitBox <gi...@apache.org>.
ferruzzi commented on a change in pull request #21920:
URL: https://github.com/apache/airflow/pull/21920#discussion_r821249267
##########
File path: airflow/providers/amazon/aws/example_dags/example_dynamodb_to_s3.py
##########
@@ -0,0 +1,43 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+from datetime import datetime
+from os import environ
+
+from airflow import DAG
+from airflow.providers.amazon.aws.transfers.dynamodb_to_s3 import DynamoDBToS3Operator
+
+TABLE_NAME = environ.get('DYNAMO_TABLE_NAME', 'ExistingDynamoDbTableName')
+BUCKET_NAME = environ.get('S3_BUCKET_NAME', 'ExistingS3BucketName')
+
+
+with DAG(
+ dag_id='example_dynamodb_to_s3',
+ schedule_interval=None,
+ start_date=datetime(2021, 1, 1),
+ tags=['example'],
+ catchup=False,
+) as dag:
+
+ # [START howto_transfer_dynamodb_to_s3]
+ backup_db = DynamoDBToS3Operator(
+ task_id='backup_db',
+ dynamodb_table_name=TABLE_NAME,
+ s3_bucket_name=BUCKET_NAME,
+ # Max output file size in bytes. If the Table is too large, multiple files will be created.
+ file_size=1000,
Review comment:
These changed should be in https://github.com/apache/airflow/pull/21920/commits/b0278a1155942ef0fdd88b745ccdabaab4578e04
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org