You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/05/04 21:09:04 UTC

[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #5810: Fix CDN DNSSEC key generation timeout

rawlinp commented on a change in pull request #5810:
URL: https://github.com/apache/trafficcontrol/pull/5810#discussion_r626109312



##########
File path: docs/source/api/v2/cdns_dnsseckeys_generate.rst
##########
@@ -32,7 +32,6 @@ Request Structure
 :effectiveDate:         An optional string containing the date and time at which the newly-generated :abbr:`ZSK (Zone-Signing Key)` and :abbr:`KSK (Key-Signing Key)` become effective, in :RFC:`3339` format. Defaults to the current time if not specified.
 :key:                   Name of the CDN
 :kskExpirationDays:     Expiration (in days) for the :abbr:`KSKs (Key-Signing Keys)`
-:name:                  Domain name used by the CDN

Review comment:
       It's not really a breaking change, it's a completely unused field that has no effect on behavior/data whatsoever. API users can continue to send it, it will just be totally ignored (as it basically was before, except without the unnecessary validation).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org