You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/10 05:23:40 UTC

[GitHub] [airflow] potiuk opened a new pull request #17524: Decreases cassandra memory requirement during Integration tests

potiuk opened a new pull request #17524:
URL: https://github.com/apache/airflow/pull/17524


   Seems that Cassandra was the main reason why a lot of memory
   was used during our integration tests. This has been overlooked
   before but seems that cassandra will always take as much as 25%
   of available memory by default and it meant for the GitHub public
   runners it was ~2 GB. Also for the self-hosted runners, even if
   they had a lot of memory, cassandra could eat up big chunk of the
   memory.
   
   With the settings added in PR Cassandra will take ~750 MB of memory
   total.
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #17524: Decreases cassandra memory requirement during Integration tests

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17524:
URL: https://github.com/apache/airflow/pull/17524#issuecomment-895739173


   This **might** be the reason why some of our tests for GitHub Public runner die with a sudden death sometimes and we have no logs for it. Let's merge and see.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #17524: Decreases cassandra memory requirement during Integration tests

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17524:
URL: https://github.com/apache/airflow/pull/17524#issuecomment-895739417


   Memory usage on my machine before:
   
   ```
   CONTAINER ID   NAME               CPU %     MEM USAGE / LIMIT     MEM %     NET I/O       BLOCK I/O      PIDS
   22a9ab781590   youthful_neumann   3.01%     8.016GiB / 29.61GiB   27.08%    2.43kB / 0B   170MB / 51MB   83
   ```
   
   And after:
   
   ```
   CONTAINER ID   NAME                    CPU %     MEM USAGE / LIMIT     MEM %     NET I/O       BLOCK I/O        PIDS
   02b77e51357b   determined_sutherland   26.34%    718.8MiB / 29.61GiB   2.37%     2.43kB / 0B   156MB / 52.2MB   82
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] github-actions[bot] commented on pull request #17524: Decreases cassandra memory use during Integration tests

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17524:
URL: https://github.com/apache/airflow/pull/17524#issuecomment-895762858


   The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk merged pull request #17524: Decreases cassandra memory use during Integration tests

Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #17524:
URL: https://github.com/apache/airflow/pull/17524


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org