You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/11/17 06:21:08 UTC
[GitHub] [incubator-doris] yangzhg opened a new pull request #4913: disable the creation of segment v1 table
yangzhg opened a new pull request #4913:
URL: https://github.com/apache/incubator-doris/pull/4913
## Proposed changes
Disable v1 storage format when creating a new table in version 0.14, as we discussed in doris-dev and Issue #4835, I will forbidden the creation of segment v1 table
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [] Bugfix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [] Documentation Update (if none of the other choices apply)
- [] Code refactor (Modify the code structure, format the code, etc...)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [x] I have create an issue on (Fix #4835), and have described the bug/feature there in detail
- [x] Compiling and unit tests pass locally with my changes
- [x] I have added tests that prove my fix is effective or that my feature works
- [] If this change need a document change, I have updated the document
- [] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] kangkaisen merged pull request #4913: disable the creation of segment v1 table
Posted by GitBox <gi...@apache.org>.
kangkaisen merged pull request #4913:
URL: https://github.com/apache/incubator-doris/pull/4913
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on a change in pull request #4913: disable the creation of segment v1 table
Posted by GitBox <gi...@apache.org>.
yangzhg commented on a change in pull request #4913:
URL: https://github.com/apache/incubator-doris/pull/4913#discussion_r525641015
##########
File path: fe/fe-core/src/main/java/org/apache/doris/common/Config.java
##########
@@ -1293,4 +1293,12 @@
*/
@ConfField
public static String http_api_extra_base_path = "";
+
+ /**
+ * Whether to support the creation of alpha rowset tables.
+ * The default is false and should only be used in emergency situations,
+ * this config should be remove in some future version
+ */
+ @ConfField
Review comment:
This configuration is just a transitional configuration, the purpose is to deal with some unexpected special scenarios and facilitate debugging and reproducing problems. Later versions will completely ban segment v1, so there is no need to make easy-to-use settings for this configuration.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #4913: disable the creation of segment v1 table
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on a change in pull request #4913:
URL: https://github.com/apache/incubator-doris/pull/4913#discussion_r525076154
##########
File path: fe/fe-core/src/main/java/org/apache/doris/common/Config.java
##########
@@ -1293,4 +1293,12 @@
*/
@ConfField
public static String http_api_extra_base_path = "";
+
+ /**
+ * Whether to support the creation of alpha rowset tables.
+ * The default is false and should only be used in emergency situations,
+ * this config should be remove in some future version
+ */
+ @ConfField
Review comment:
mutable = true?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org