You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2021/07/06 13:01:09 UTC

[GitHub] [avro] martin-g opened a new pull request #1282: AVRO-3169: Fix 'cargo build' by removing trailing comma

martin-g opened a new pull request #1282:
URL: https://github.com/apache/avro/pull/1282


   
   ### Jira
   
      https://issues.apache.org/jira/browse/AVRO-3169
   
   ### Tests
   
   No new tests because there is no change in the behavior/functionality
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] martin-g commented on pull request #1282: AVRO-3169: Fix 'cargo build' by removing trailing comma

Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #1282:
URL: https://github.com/apache/avro/pull/1282#issuecomment-875526457


   Please ignore my two previous comments! 
   I was testing on my ARM64 machine where I was confused that I was using latest Rust version.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] martin-g commented on pull request #1282: AVRO-3169: Fix 'cargo build' by removing trailing comma

Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #1282:
URL: https://github.com/apache/avro/pull/1282#issuecomment-875503366


   `cargo bench` also fails due to this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] martin-g commented on pull request #1282: AVRO-3169: Fix 'cargo build' by removing trailing comma

Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #1282:
URL: https://github.com/apache/avro/pull/1282#issuecomment-875432506


   @iemejia `cargo clippy --all-targets --all-features -- -Dclippy::all` (part of `lang/rust/.pre-commit-config.yaml`) also complains about this comma:
   
   ```
   error: no rules expected the token `,`
      --> src/schema.rs:163:37
       |
   163 |                 | SchemaKind::String,
       |                                     ^ no rules expected this token in macro call
   
       Checking criterion v0.3.4
   error: aborting due to previous error
   
   error: could not compile `avro-rs`.
   ```
   
   Do you see a problem in removing this comma ?
   This way even older versions of rustc could be used.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] iemejia commented on pull request #1282: AVRO-3169: Fix 'cargo build' by removing trailing comma

Posted by GitBox <gi...@apache.org>.
iemejia commented on pull request #1282:
URL: https://github.com/apache/avro/pull/1282#issuecomment-875359031






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] iemejia closed pull request #1282: AVRO-3169: Fix 'cargo build' by removing trailing comma

Posted by GitBox <gi...@apache.org>.
iemejia closed pull request #1282:
URL: https://github.com/apache/avro/pull/1282


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org