You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Arfrever Frehtes Taifersar Arahesis <Ar...@GMail.Com> on 2009/03/16 16:44:26 UTC
Re: svn commit: r36602 - branches/1.6.x/subversion/include
2009-03-16 17:34 Hyrum K. Wright <hy...@hyrumwright.org> napisał(a):
> Author: hwright
> Date: Mon Mar 16 09:34:11 2009
> New Revision: 36602
>
> Log:
> Using my prerogative as release manager to add an explanitory note as a result
> of the merge in r36589.
>
> * subversion/include/svn_error_codes.h:
> Explain why we skipped an error code.
>
> Modified:
> branches/1.6.x/subversion/include/svn_error_codes.h
>
> Modified: branches/1.6.x/subversion/include/svn_error_codes.h
> URL: http://svn.collab.net/viewvc/svn/branches/1.6.x/subversion/include/svn_error_codes.h?pathrev=36602&r1=36601&r2=36602
> ==============================================================================
> --- branches/1.6.x/subversion/include/svn_error_codes.h Mon Mar 16 09:26:18 2009 (r36601)
> +++ branches/1.6.x/subversion/include/svn_error_codes.h Mon Mar 16 09:34:11 2009 (r36602)
> @@ -842,6 +842,8 @@ SVN_ERROR_START
> SVN_ERR_RA_DAV_CATEGORY_START + 11,
> "Repository has been moved")
>
> + /* SVN_ERR_RA_DAV_CATEGORY_START + 12 is reserved for use in 1.7. */
> +
> /** @since New in 1.6 */
> SVN_ERRDEF(SVN_ERR_RA_DAV_FORBIDDEN,
> SVN_ERR_RA_DAV_CATEGORY_START + 13,
I suggest to swap SVN_ERR_RA_DAV_CONN_TIMEOUT and
SVN_ERR_RA_DAV_FORBIDDEN on trunk and fix definition of
SVN_ERR_RA_DAV_FORBIDDEN on the 1.6.x branch.
It would be obvious fix, but I preventively vote +1 for the suggestion
described above.
--
Arfrever Frehtes Taifersar Arahesis
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1334253
Re: svn commit: r36602 - branches/1.6.x/subversion/include
Posted by "Hyrum K. Wright" <hy...@hyrumwright.org>.
On Mar 16, 2009, at 11:52 AM, Greg Stein wrote:
> On Mon, Mar 16, 2009 at 17:44, Arfrever Frehtes Taifersar Arahesis
> <Ar...@gmail.com> wrote:
>> 2009-03-16 17:34 Hyrum K. Wright <hy...@hyrumwright.org> napisał(a):
>>> Author: hwright
>>> Date: Mon Mar 16 09:34:11 2009
>>> New Revision: 36602
>>>
>>> Log:
>>> Using my prerogative as release manager to add an explanitory note
>>> as a result
>>> of the merge in r36589.
>>>
>>> * subversion/include/svn_error_codes.h:
>>> Explain why we skipped an error code.
>>>
>>> Modified:
>>> branches/1.6.x/subversion/include/svn_error_codes.h
>>>
>>> Modified: branches/1.6.x/subversion/include/svn_error_codes.h
>>> URL: http://svn.collab.net/viewvc/svn/branches/1.6.x/subversion/include/svn_error_codes.h?pathrev=36602&r1=36601&r2=36602
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> ====================================================================
>>> --- branches/1.6.x/subversion/include/svn_error_codes.h Mon Mar 16
>>> 09:26:18 2009 (r36601)
>>> +++ branches/1.6.x/subversion/include/svn_error_codes.h Mon Mar 16
>>> 09:34:11 2009 (r36602)
>>> @@ -842,6 +842,8 @@ SVN_ERROR_START
>>> SVN_ERR_RA_DAV_CATEGORY_START + 11,
>>> "Repository has been moved")
>>>
>>> + /* SVN_ERR_RA_DAV_CATEGORY_START + 12 is reserved for use in
>>> 1.7. */
>>> +
>>> /** @since New in 1.6 */
>>> SVN_ERRDEF(SVN_ERR_RA_DAV_FORBIDDEN,
>>> SVN_ERR_RA_DAV_CATEGORY_START + 13,
>>
>> I suggest to swap SVN_ERR_RA_DAV_CONN_TIMEOUT and
>> SVN_ERR_RA_DAV_FORBIDDEN on trunk and fix definition of
>> SVN_ERR_RA_DAV_FORBIDDEN on the 1.6.x branch.
>> It would be obvious fix, but I preventively vote +1 for the
>> suggestion
>> described above.
>
> I see no reason to do this. It is perfectly fine for 1.6 to have
> non-contiguous error codes.
>
> Look at SVN_ERR_ENTRY_CATEGORY + 1 ... that has been empty for years.
> We have plenty of deprecated slots.
>
> There is no need for churn here.
+1
-Hyrum
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1334384
Re: svn commit: r36602 - branches/1.6.x/subversion/include
Posted by Greg Stein <gs...@gmail.com>.
On Mon, Mar 16, 2009 at 17:44, Arfrever Frehtes Taifersar Arahesis
<Ar...@gmail.com> wrote:
> 2009-03-16 17:34 Hyrum K. Wright <hy...@hyrumwright.org> napisał(a):
>> Author: hwright
>> Date: Mon Mar 16 09:34:11 2009
>> New Revision: 36602
>>
>> Log:
>> Using my prerogative as release manager to add an explanitory note as a result
>> of the merge in r36589.
>>
>> * subversion/include/svn_error_codes.h:
>> Explain why we skipped an error code.
>>
>> Modified:
>> branches/1.6.x/subversion/include/svn_error_codes.h
>>
>> Modified: branches/1.6.x/subversion/include/svn_error_codes.h
>> URL: http://svn.collab.net/viewvc/svn/branches/1.6.x/subversion/include/svn_error_codes.h?pathrev=36602&r1=36601&r2=36602
>> ==============================================================================
>> --- branches/1.6.x/subversion/include/svn_error_codes.h Mon Mar 16 09:26:18 2009 (r36601)
>> +++ branches/1.6.x/subversion/include/svn_error_codes.h Mon Mar 16 09:34:11 2009 (r36602)
>> @@ -842,6 +842,8 @@ SVN_ERROR_START
>> SVN_ERR_RA_DAV_CATEGORY_START + 11,
>> "Repository has been moved")
>>
>> + /* SVN_ERR_RA_DAV_CATEGORY_START + 12 is reserved for use in 1.7. */
>> +
>> /** @since New in 1.6 */
>> SVN_ERRDEF(SVN_ERR_RA_DAV_FORBIDDEN,
>> SVN_ERR_RA_DAV_CATEGORY_START + 13,
>
> I suggest to swap SVN_ERR_RA_DAV_CONN_TIMEOUT and
> SVN_ERR_RA_DAV_FORBIDDEN on trunk and fix definition of
> SVN_ERR_RA_DAV_FORBIDDEN on the 1.6.x branch.
> It would be obvious fix, but I preventively vote +1 for the suggestion
> described above.
I see no reason to do this. It is perfectly fine for 1.6 to have
non-contiguous error codes.
Look at SVN_ERR_ENTRY_CATEGORY + 1 ... that has been empty for years.
We have plenty of deprecated slots.
There is no need for churn here.
Cheers,
-g
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1334292