[Impala-ASF-CR] IMPALA-10583: Fix bug on unbounded result spooling memory config.

["Aman Sinha (Code Review)" <ge...@cloudera.org>]

Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/17187 )

Change subject: IMPALA-10583: Fix bug on unbounded result spooling memory config.
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

Thanks for fixing the edge cases. One related question below.

http://gerrit.cloudera.org:8080/#/c/17187/1/be/src/exec/buffered-plan-root-sink.cc
File be/src/exec/buffered-plan-root-sink.cc:

http://gerrit.cloudera.org:8080/#/c/17187/1/be/src/exec/buffered-plan-root-sink.cc@55
PS1, Line 55:   if (max_spilled_mem <= 0) max_spilled_mem = INT64_MAX;
In practice, this would eventually encounter other limits such as running out of disk space if too much has been spilled but do we check for disk space limits elsewhere ?



-- 
To view, visit http://gerrit.cloudera.org:8080/17187
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If8f5e3668281bba8813f8082f45b4faa7721530e
Gerrit-Change-Number: 17187
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Apr 2021 15:57:48 +0000
Gerrit-HasComments: Yes