You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/09/07 19:33:01 UTC

[GitHub] [skywalking-eyes] guilload opened a new pull request #66: Fix file extension conflict between RenderScript and Rust

guilload opened a new pull request #66:
URL: https://github.com/apache/skywalking-eyes/pull/66


   `comment_style_id` for Rust was added in #29, but currently, running `header fix` for Rust files does not work and displays `unsupported files: ...`.
   
   The language configuration file contains two entries for the `.rs` file extension: RenderScript and Rust. `.rs` files end up matching RenderScript, which does not have a comment style. Locally, I fixed this for Rust by removing RenderScript from the language configuration file.
   
   However, in this PR, I choose to set the command style for RenderScript to double slash, which is supported by both languages (and actually the [preferred](https://github.com/rust-lang/book/issues/693#issuecomment-301200629) style for Rust).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-eyes] kezhenxu94 merged pull request #66: Fix file extension conflict between RenderScript and Rust

Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #66:
URL: https://github.com/apache/skywalking-eyes/pull/66


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org