You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openjpa.apache.org by Francesco Chicchiriccò <il...@apache.org> on 2020/04/27 14:55:29 UTC
Fwd: Build failed in Jenkins: OpenJPA-master #110
Hi all,
FYI, Jenkins keep failing (see attachments).
Can someone check recent commits?
Regards.
Re: Build failed in Jenkins: OpenJPA-master #110
Posted by Maxim Solodovnik <so...@gmail.com>.
Thanks!
Will try to do in a day or two :)
On Mon, 27 Apr 2020 at 23:08, Romain Manni-Bucau <rm...@gmail.com> wrote:
>
> Personally, I'd just extend SingleEMFTestCase , create a db state in plain
> jdbc and create a configured emf (needs to call createEntityManager() to
> actually call the ddl) and check the db grabbing a connection from
> DriverManager.
>
> side note: can be a good opportunity to reduce jpa 2.1 debt:
> https://github.com/apache/openjpa/blob/master/openjpa-persistence/src/main/java/org/apache/openjpa/persistence/PersistenceProviderImpl.java#L230
> too
> (would be useful in such a test)
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> | Blog
> <https://rmannibucau.metawerx.net/> | Old Blog
> <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> <https://www.packtpub.com/application-development/java-ee-8-high-performance>
>
>
> Le lun. 27 avr. 2020 à 17:37, Maxim Solodovnik <so...@gmail.com> a
> écrit :
>
> > I'm not sure where this test should be added
> > Can you point me to the good test for existing functionality, so I can
> > extend it?
> >
> > On Mon, 27 Apr 2020 at 22:35, Romain Manni-Bucau <rm...@gmail.com>
> > wrote:
> > >
> > > no objection from me (even if I'd still like a test ensuring the fix does
> > > something new and really fixes an issue ;))
> > >
> > > Romain Manni-Bucau
> > > @rmannibucau <https://twitter.com/rmannibucau> | Blog
> > > <https://rmannibucau.metawerx.net/> | Old Blog
> > > <http://rmannibucau.wordpress.com> | Github <
> > https://github.com/rmannibucau> |
> > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> > > <
> > https://www.packtpub.com/application-development/java-ee-8-high-performance
> > >
> > >
> > >
> > > Le lun. 27 avr. 2020 à 17:21, Maxim Solodovnik <so...@gmail.com> a
> > > écrit :
> > >
> > > > Can I merge my PR https://github.com/apache/openjpa/pull/59 ?
> > > >
> > > > On Mon, 27 Apr 2020 at 21:57, Romain Manni-Bucau <
> > rmannibucau@gmail.com>
> > > > wrote:
> > > > >
> > > > > Hi Francesco,
> > > > >
> > > > > It requires
> > > > >
> > > >
> > https://repository.apache.org/content/repositories/orgapachegeronimo-1123
> > > > > staging repo (I'm trying to prepare the coming release).
> > > > > Thought it was better to not add it then remove it from the pom but
> > we
> > > > can
> > > > > do it if you think it is worth it.
> > > > >
> > > > >
> > > > > Romain Manni-Bucau
> > > > > @rmannibucau <https://twitter.com/rmannibucau> | Blog
> > > > > <https://rmannibucau.metawerx.net/> | Old Blog
> > > > > <http://rmannibucau.wordpress.com> | Github <
> > > > https://github.com/rmannibucau> |
> > > > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> > > > > <
> > > >
> > https://www.packtpub.com/application-development/java-ee-8-high-performance
> > > > >
> > > > >
> > > > >
> > > > > Le lun. 27 avr. 2020 à 16:55, Francesco Chicchiriccò <
> > > > ilgrosso@apache.org>
> > > > > a écrit :
> > > > >
> > > > > > Hi all,
> > > > > > FYI, Jenkins keep failing (see attachments).
> > > > > >
> > > > > > Can someone check recent commits?
> > > > > >
> > > > > > Regards.
> > > > > >
> > > > > >
> > > > > >
> > > >
> > > >
> > > >
> > > > --
> > > > Best regards,
> > > > Maxim
> > > >
> >
> >
> >
> > --
> > Best regards,
> > Maxim
> >
--
Best regards,
Maxim
Re: Build failed in Jenkins: OpenJPA-master #110
Posted by Romain Manni-Bucau <rm...@gmail.com>.
Personally, I'd just extend SingleEMFTestCase , create a db state in plain
jdbc and create a configured emf (needs to call createEntityManager() to
actually call the ddl) and check the db grabbing a connection from
DriverManager.
side note: can be a good opportunity to reduce jpa 2.1 debt:
https://github.com/apache/openjpa/blob/master/openjpa-persistence/src/main/java/org/apache/openjpa/persistence/PersistenceProviderImpl.java#L230
too
(would be useful in such a test)
Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> | Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>
Le lun. 27 avr. 2020 à 17:37, Maxim Solodovnik <so...@gmail.com> a
écrit :
> I'm not sure where this test should be added
> Can you point me to the good test for existing functionality, so I can
> extend it?
>
> On Mon, 27 Apr 2020 at 22:35, Romain Manni-Bucau <rm...@gmail.com>
> wrote:
> >
> > no objection from me (even if I'd still like a test ensuring the fix does
> > something new and really fixes an issue ;))
> >
> > Romain Manni-Bucau
> > @rmannibucau <https://twitter.com/rmannibucau> | Blog
> > <https://rmannibucau.metawerx.net/> | Old Blog
> > <http://rmannibucau.wordpress.com> | Github <
> https://github.com/rmannibucau> |
> > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> > <
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> >
> >
> >
> > Le lun. 27 avr. 2020 à 17:21, Maxim Solodovnik <so...@gmail.com> a
> > écrit :
> >
> > > Can I merge my PR https://github.com/apache/openjpa/pull/59 ?
> > >
> > > On Mon, 27 Apr 2020 at 21:57, Romain Manni-Bucau <
> rmannibucau@gmail.com>
> > > wrote:
> > > >
> > > > Hi Francesco,
> > > >
> > > > It requires
> > > >
> > >
> https://repository.apache.org/content/repositories/orgapachegeronimo-1123
> > > > staging repo (I'm trying to prepare the coming release).
> > > > Thought it was better to not add it then remove it from the pom but
> we
> > > can
> > > > do it if you think it is worth it.
> > > >
> > > >
> > > > Romain Manni-Bucau
> > > > @rmannibucau <https://twitter.com/rmannibucau> | Blog
> > > > <https://rmannibucau.metawerx.net/> | Old Blog
> > > > <http://rmannibucau.wordpress.com> | Github <
> > > https://github.com/rmannibucau> |
> > > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> > > > <
> > >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > > >
> > > >
> > > >
> > > > Le lun. 27 avr. 2020 à 16:55, Francesco Chicchiriccò <
> > > ilgrosso@apache.org>
> > > > a écrit :
> > > >
> > > > > Hi all,
> > > > > FYI, Jenkins keep failing (see attachments).
> > > > >
> > > > > Can someone check recent commits?
> > > > >
> > > > > Regards.
> > > > >
> > > > >
> > > > >
> > >
> > >
> > >
> > > --
> > > Best regards,
> > > Maxim
> > >
>
>
>
> --
> Best regards,
> Maxim
>
Re: Build failed in Jenkins: OpenJPA-master #110
Posted by Maxim Solodovnik <so...@gmail.com>.
I'm not sure where this test should be added
Can you point me to the good test for existing functionality, so I can
extend it?
On Mon, 27 Apr 2020 at 22:35, Romain Manni-Bucau <rm...@gmail.com> wrote:
>
> no objection from me (even if I'd still like a test ensuring the fix does
> something new and really fixes an issue ;))
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> | Blog
> <https://rmannibucau.metawerx.net/> | Old Blog
> <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> <https://www.packtpub.com/application-development/java-ee-8-high-performance>
>
>
> Le lun. 27 avr. 2020 à 17:21, Maxim Solodovnik <so...@gmail.com> a
> écrit :
>
> > Can I merge my PR https://github.com/apache/openjpa/pull/59 ?
> >
> > On Mon, 27 Apr 2020 at 21:57, Romain Manni-Bucau <rm...@gmail.com>
> > wrote:
> > >
> > > Hi Francesco,
> > >
> > > It requires
> > >
> > https://repository.apache.org/content/repositories/orgapachegeronimo-1123
> > > staging repo (I'm trying to prepare the coming release).
> > > Thought it was better to not add it then remove it from the pom but we
> > can
> > > do it if you think it is worth it.
> > >
> > >
> > > Romain Manni-Bucau
> > > @rmannibucau <https://twitter.com/rmannibucau> | Blog
> > > <https://rmannibucau.metawerx.net/> | Old Blog
> > > <http://rmannibucau.wordpress.com> | Github <
> > https://github.com/rmannibucau> |
> > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> > > <
> > https://www.packtpub.com/application-development/java-ee-8-high-performance
> > >
> > >
> > >
> > > Le lun. 27 avr. 2020 à 16:55, Francesco Chicchiriccò <
> > ilgrosso@apache.org>
> > > a écrit :
> > >
> > > > Hi all,
> > > > FYI, Jenkins keep failing (see attachments).
> > > >
> > > > Can someone check recent commits?
> > > >
> > > > Regards.
> > > >
> > > >
> > > >
> >
> >
> >
> > --
> > Best regards,
> > Maxim
> >
--
Best regards,
Maxim
Re: Build failed in Jenkins: OpenJPA-master #110
Posted by Romain Manni-Bucau <rm...@gmail.com>.
no objection from me (even if I'd still like a test ensuring the fix does
something new and really fixes an issue ;))
Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> | Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>
Le lun. 27 avr. 2020 à 17:21, Maxim Solodovnik <so...@gmail.com> a
écrit :
> Can I merge my PR https://github.com/apache/openjpa/pull/59 ?
>
> On Mon, 27 Apr 2020 at 21:57, Romain Manni-Bucau <rm...@gmail.com>
> wrote:
> >
> > Hi Francesco,
> >
> > It requires
> >
> https://repository.apache.org/content/repositories/orgapachegeronimo-1123
> > staging repo (I'm trying to prepare the coming release).
> > Thought it was better to not add it then remove it from the pom but we
> can
> > do it if you think it is worth it.
> >
> >
> > Romain Manni-Bucau
> > @rmannibucau <https://twitter.com/rmannibucau> | Blog
> > <https://rmannibucau.metawerx.net/> | Old Blog
> > <http://rmannibucau.wordpress.com> | Github <
> https://github.com/rmannibucau> |
> > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> > <
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> >
> >
> >
> > Le lun. 27 avr. 2020 à 16:55, Francesco Chicchiriccò <
> ilgrosso@apache.org>
> > a écrit :
> >
> > > Hi all,
> > > FYI, Jenkins keep failing (see attachments).
> > >
> > > Can someone check recent commits?
> > >
> > > Regards.
> > >
> > >
> > >
>
>
>
> --
> Best regards,
> Maxim
>
Re: Build failed in Jenkins: OpenJPA-master #110
Posted by Maxim Solodovnik <so...@gmail.com>.
Can I merge my PR https://github.com/apache/openjpa/pull/59 ?
On Mon, 27 Apr 2020 at 21:57, Romain Manni-Bucau <rm...@gmail.com> wrote:
>
> Hi Francesco,
>
> It requires
> https://repository.apache.org/content/repositories/orgapachegeronimo-1123
> staging repo (I'm trying to prepare the coming release).
> Thought it was better to not add it then remove it from the pom but we can
> do it if you think it is worth it.
>
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> | Blog
> <https://rmannibucau.metawerx.net/> | Old Blog
> <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> <https://www.packtpub.com/application-development/java-ee-8-high-performance>
>
>
> Le lun. 27 avr. 2020 à 16:55, Francesco Chicchiriccò <il...@apache.org>
> a écrit :
>
> > Hi all,
> > FYI, Jenkins keep failing (see attachments).
> >
> > Can someone check recent commits?
> >
> > Regards.
> >
> >
> >
--
Best regards,
Maxim
Re: Build failed in Jenkins: OpenJPA-master #110
Posted by Romain Manni-Bucau <rm...@gmail.com>.
Hi Francesco,
It requires
https://repository.apache.org/content/repositories/orgapachegeronimo-1123
staging repo (I'm trying to prepare the coming release).
Thought it was better to not add it then remove it from the pom but we can
do it if you think it is worth it.
Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> | Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>
Le lun. 27 avr. 2020 à 16:55, Francesco Chicchiriccò <il...@apache.org>
a écrit :
> Hi all,
> FYI, Jenkins keep failing (see attachments).
>
> Can someone check recent commits?
>
> Regards.
>
>
>