You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/05/23 18:30:30 UTC
[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request
#4235: Add config to disable HLC realtime segment completion
mcvsubbu commented on a change in pull request #4235: Add config to disable HLC realtime segment completion
URL: https://github.com/apache/incubator-pinot/pull/4235#discussion_r287076822
##########
File path: pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java
##########
@@ -136,7 +136,7 @@ private static long getRandomInitialDelayInSeconds() {
private static final String REALTIME_SEGMENT_METADATA_COMMIT_NUMLOCKS =
"controller.realtime.segment.metadata.commit.numLocks";
private static final String ENABLE_STORAGE_QUOTA_CHECK = "controller.enable.storage.quota.check";
-
+ private static final String ENABLE_HLC_REALTIME_SEGMENT_COMPLETION = "controller.enable.hlc.realtime.segment.completion";
Review comment:
Can we rename the config as ALLOW_HLC_TABLES? Please document the config clearly. If the config says "true"(default), then the behavior is unchanged. If the config is set to "false", then the following will happen:
* Existing HLC realtime tables will stop consumption
* Creation of mew HLC tables will be disallowed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org