You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "Daniel Ellis (JIRA)" <ji...@apache.org> on 2009/07/08 14:46:06 UTC
[jira] Created: (AMQNET-175) Trunk fails to build for
compact-framework, due to [Serializable] attributes on exception classes.
Trunk fails to build for compact-framework, due to [Serializable] attributes on exception classes.
--------------------------------------------------------------------------------------------------
Key: AMQNET-175
URL: https://issues.apache.org/activemq/browse/AMQNET-175
Project: ActiveMQ .Net
Issue Type: Bug
Environment: Building trunk using nant on Windows XP
Reporter: Daniel Ellis
Assignee: Jim Gomes
The trunk fails to build due to the [Serializable] attributes that are on many of the exception classes. Removing the attributes, which I have done in the attached patch, resolves the issue and compilation then succeeds.
I am not sure about the consequences of removing the serializable attributes, but did look through the revision history and cannot see any consistency of when certain exceptions have this attribute.
Another option would be to wrap compile time directives around the attributes so they are not included in the compact framework build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AMQNET-175) Trunk fails to build for
compact-framework, due to [Serializable] attributes on exception classes.
Posted by "Jim Gomes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQNET-175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Gomes updated AMQNET-175:
-----------------------------
Priority: Trivial (was: Major)
Affects Version/s: 1.1.0
Fix Version/s: 1.2.0
> Trunk fails to build for compact-framework, due to [Serializable] attributes on exception classes.
> --------------------------------------------------------------------------------------------------
>
> Key: AMQNET-175
> URL: https://issues.apache.org/activemq/browse/AMQNET-175
> Project: ActiveMQ .Net
> Issue Type: Bug
> Affects Versions: 1.1.0
> Environment: Building trunk using nant on Windows XP
> Reporter: Daniel Ellis
> Assignee: Jim Gomes
> Priority: Trivial
> Fix For: 1.2.0
>
> Attachments: RemoveSerializableAttributes.patch
>
>
> The trunk fails to build due to the [Serializable] attributes that are on many of the exception classes. Removing the attributes, which I have done in the attached patch, resolves the issue and compilation then succeeds.
> I am not sure about the consequences of removing the serializable attributes, but did look through the revision history and cannot see any consistency of when certain exceptions have this attribute.
> Another option would be to wrap compile time directives around the attributes so they are not included in the compact framework build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AMQNET-175) Trunk fails to build for
compact-framework, due to [Serializable] attributes on exception classes.
Posted by "Daniel Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQNET-175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Ellis updated AMQNET-175:
--------------------------------
Attachment: RemoveSerializableAttributes.patch
Simple patch which removes the serializable attributes from the exception classes.
> Trunk fails to build for compact-framework, due to [Serializable] attributes on exception classes.
> --------------------------------------------------------------------------------------------------
>
> Key: AMQNET-175
> URL: https://issues.apache.org/activemq/browse/AMQNET-175
> Project: ActiveMQ .Net
> Issue Type: Bug
> Environment: Building trunk using nant on Windows XP
> Reporter: Daniel Ellis
> Assignee: Jim Gomes
> Attachments: RemoveSerializableAttributes.patch
>
>
> The trunk fails to build due to the [Serializable] attributes that are on many of the exception classes. Removing the attributes, which I have done in the attached patch, resolves the issue and compilation then succeeds.
> I am not sure about the consequences of removing the serializable attributes, but did look through the revision history and cannot see any consistency of when certain exceptions have this attribute.
> Another option would be to wrap compile time directives around the attributes so they are not included in the compact framework build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AMQNET-175) Trunk fails to build for
compact-framework, due to [Serializable] attributes on exception classes.
Posted by "Daniel Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQNET-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=52732#action_52732 ]
Daniel Ellis commented on AMQNET-175:
-------------------------------------
On a side note, when I came across this problem, my first attempt was to just compile for net-2.0 and so skipping the compact framework. I tried compiling with the following command:-
nant -t:net-2.0
However, it continued to build all target frameworks. Should I raise this as a separate issue?
> Trunk fails to build for compact-framework, due to [Serializable] attributes on exception classes.
> --------------------------------------------------------------------------------------------------
>
> Key: AMQNET-175
> URL: https://issues.apache.org/activemq/browse/AMQNET-175
> Project: ActiveMQ .Net
> Issue Type: Bug
> Environment: Building trunk using nant on Windows XP
> Reporter: Daniel Ellis
> Assignee: Jim Gomes
> Attachments: RemoveSerializableAttributes.patch
>
>
> The trunk fails to build due to the [Serializable] attributes that are on many of the exception classes. Removing the attributes, which I have done in the attached patch, resolves the issue and compilation then succeeds.
> I am not sure about the consequences of removing the serializable attributes, but did look through the revision history and cannot see any consistency of when certain exceptions have this attribute.
> Another option would be to wrap compile time directives around the attributes so they are not included in the compact framework build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AMQNET-175) Trunk fails to build for
compact-framework, due to [Serializable] attributes on exception classes.
Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQNET-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=52751#action_52751 ]
Timothy Bish commented on AMQNET-175:
-------------------------------------
I vote we remove this attribute from the Exception classes, I don't see any reason we would need them for NMS
> Trunk fails to build for compact-framework, due to [Serializable] attributes on exception classes.
> --------------------------------------------------------------------------------------------------
>
> Key: AMQNET-175
> URL: https://issues.apache.org/activemq/browse/AMQNET-175
> Project: ActiveMQ .Net
> Issue Type: Bug
> Environment: Building trunk using nant on Windows XP
> Reporter: Daniel Ellis
> Assignee: Jim Gomes
> Attachments: RemoveSerializableAttributes.patch
>
>
> The trunk fails to build due to the [Serializable] attributes that are on many of the exception classes. Removing the attributes, which I have done in the attached patch, resolves the issue and compilation then succeeds.
> I am not sure about the consequences of removing the serializable attributes, but did look through the revision history and cannot see any consistency of when certain exceptions have this attribute.
> Another option would be to wrap compile time directives around the attributes so they are not included in the compact framework build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (AMQNET-175) Trunk fails to build for
compact-framework, due to [Serializable] attributes on exception classes.
Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQNET-175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Timothy Bish reassigned AMQNET-175:
-----------------------------------
Assignee: Timothy Bish (was: Jim Gomes)
> Trunk fails to build for compact-framework, due to [Serializable] attributes on exception classes.
> --------------------------------------------------------------------------------------------------
>
> Key: AMQNET-175
> URL: https://issues.apache.org/activemq/browse/AMQNET-175
> Project: ActiveMQ .Net
> Issue Type: Bug
> Affects Versions: 1.1.0
> Environment: Building trunk using nant on Windows XP
> Reporter: Daniel Ellis
> Assignee: Timothy Bish
> Priority: Trivial
> Fix For: 1.2.0
>
> Attachments: RemoveSerializableAttributes.patch
>
>
> The trunk fails to build due to the [Serializable] attributes that are on many of the exception classes. Removing the attributes, which I have done in the attached patch, resolves the issue and compilation then succeeds.
> I am not sure about the consequences of removing the serializable attributes, but did look through the revision history and cannot see any consistency of when certain exceptions have this attribute.
> Another option would be to wrap compile time directives around the attributes so they are not included in the compact framework build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AMQNET-175) Trunk fails to build for
compact-framework, due to [Serializable] attributes on exception classes.
Posted by "Jim Gomes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQNET-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=52749#action_52749 ]
Jim Gomes commented on AMQNET-175:
----------------------------------
Hi Daniel,
I am able to build the Compact Framework assemblies without a problem with the code as-is. I have a build machine set up that builds the assemblies, and it works just fine. I am curious about your compiler environment, and what Windows SDK version you are using. You can see that the current source code from the 1.1.0 branch, which includes the same attributes as the trunk, can be built by downloading the shipping candidate assemblies from here: http://people.apache.org/~jgomes/nms_1.1.0.
I'm not necessarily against removing the Serializable attribute, but it just makes me wonder what is causing the discrepancy in the two build environments that is not allowing your build to work. Perhaps you have an older SDK?
> Trunk fails to build for compact-framework, due to [Serializable] attributes on exception classes.
> --------------------------------------------------------------------------------------------------
>
> Key: AMQNET-175
> URL: https://issues.apache.org/activemq/browse/AMQNET-175
> Project: ActiveMQ .Net
> Issue Type: Bug
> Environment: Building trunk using nant on Windows XP
> Reporter: Daniel Ellis
> Assignee: Jim Gomes
> Attachments: RemoveSerializableAttributes.patch
>
>
> The trunk fails to build due to the [Serializable] attributes that are on many of the exception classes. Removing the attributes, which I have done in the attached patch, resolves the issue and compilation then succeeds.
> I am not sure about the consequences of removing the serializable attributes, but did look through the revision history and cannot see any consistency of when certain exceptions have this attribute.
> Another option would be to wrap compile time directives around the attributes so they are not included in the compact framework build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AMQNET-175) Trunk fails to build for
compact-framework, due to [Serializable] attributes on exception classes.
Posted by "Jim Gomes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQNET-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=52753#action_52753 ]
Jim Gomes commented on AMQNET-175:
----------------------------------
I agree they should probably be removed. As I mentioned, my main concern was the discrepancy in the build environments. Thanks for following up on that, Daniel. I'm going to lower the priority from Major to Trivial and then schedule the fix for 1.2.0.
> Trunk fails to build for compact-framework, due to [Serializable] attributes on exception classes.
> --------------------------------------------------------------------------------------------------
>
> Key: AMQNET-175
> URL: https://issues.apache.org/activemq/browse/AMQNET-175
> Project: ActiveMQ .Net
> Issue Type: Bug
> Affects Versions: 1.1.0
> Environment: Building trunk using nant on Windows XP
> Reporter: Daniel Ellis
> Assignee: Jim Gomes
> Fix For: 1.2.0
>
> Attachments: RemoveSerializableAttributes.patch
>
>
> The trunk fails to build due to the [Serializable] attributes that are on many of the exception classes. Removing the attributes, which I have done in the attached patch, resolves the issue and compilation then succeeds.
> I am not sure about the consequences of removing the serializable attributes, but did look through the revision history and cannot see any consistency of when certain exceptions have this attribute.
> Another option would be to wrap compile time directives around the attributes so they are not included in the compact framework build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (AMQNET-175) Trunk fails to build for
compact-framework, due to [Serializable] attributes on exception classes.
Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQNET-175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Timothy Bish resolved AMQNET-175.
---------------------------------
Resolution: Fixed
Fixed in trunk
> Trunk fails to build for compact-framework, due to [Serializable] attributes on exception classes.
> --------------------------------------------------------------------------------------------------
>
> Key: AMQNET-175
> URL: https://issues.apache.org/activemq/browse/AMQNET-175
> Project: ActiveMQ .Net
> Issue Type: Bug
> Affects Versions: 1.1.0
> Environment: Building trunk using nant on Windows XP
> Reporter: Daniel Ellis
> Assignee: Timothy Bish
> Priority: Trivial
> Fix For: 1.2.0
>
> Attachments: RemoveSerializableAttributes.patch
>
>
> The trunk fails to build due to the [Serializable] attributes that are on many of the exception classes. Removing the attributes, which I have done in the attached patch, resolves the issue and compilation then succeeds.
> I am not sure about the consequences of removing the serializable attributes, but did look through the revision history and cannot see any consistency of when certain exceptions have this attribute.
> Another option would be to wrap compile time directives around the attributes so they are not included in the compact framework build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AMQNET-175) Trunk fails to build for
compact-framework, due to [Serializable] attributes on exception classes.
Posted by "Daniel Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQNET-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=52750#action_52750 ]
Daniel Ellis commented on AMQNET-175:
-------------------------------------
Thanks Jim,
Sorry, I was not aware that the Serializable attribute had sneaked in to the compact framework 2.0 with SP1.
I downloaded and installed the ".NET Compact Framework 2.0 Service Pack 2 Redistributable", and then NMS compiled using Nant without a problem.
Although the serializable attribute has now been included, the attribute still has no effect, see the following note taken from http://msdn.microsoft.com/en-us/library/system.serializableattribute.aspx
"Windows Mobile for Pocket PC, Windows Mobile for Smartphone, Windows CE Platform Note:
The SerializableAttribute attribute is present in the .NET Compact Framework for compatibility only, and will be ignored if used."
> Trunk fails to build for compact-framework, due to [Serializable] attributes on exception classes.
> --------------------------------------------------------------------------------------------------
>
> Key: AMQNET-175
> URL: https://issues.apache.org/activemq/browse/AMQNET-175
> Project: ActiveMQ .Net
> Issue Type: Bug
> Environment: Building trunk using nant on Windows XP
> Reporter: Daniel Ellis
> Assignee: Jim Gomes
> Attachments: RemoveSerializableAttributes.patch
>
>
> The trunk fails to build due to the [Serializable] attributes that are on many of the exception classes. Removing the attributes, which I have done in the attached patch, resolves the issue and compilation then succeeds.
> I am not sure about the consequences of removing the serializable attributes, but did look through the revision history and cannot see any consistency of when certain exceptions have this attribute.
> Another option would be to wrap compile time directives around the attributes so they are not included in the compact framework build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.