You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/05/01 15:27:01 UTC
[GitHub] [shardingsphere] strongduanmu opened a new pull request #5406: optimize performance of partitionRangeMap initialization
strongduanmu opened a new pull request #5406:
URL: https://github.com/apache/shardingsphere/pull/5406
Ref #5280 .
Changes proposed in this pull request:
- optimize performance of partitionRangeMap initialization
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-io commented on pull request #5406: optimize performance of partitionRangeMap initialization
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #5406:
URL: https://github.com/apache/shardingsphere/pull/5406#issuecomment-622444329
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5406?src=pr&el=h1) Report
> Merging [#5406](https://codecov.io/gh/apache/shardingsphere/pull/5406?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/dda2c5f474f4f8066305f0609f5c69ab79faf154&el=desc) will **increase** coverage by `0.00%`.
> The diff coverage is `95.00%`.
[](https://codecov.io/gh/apache/shardingsphere/pull/5406?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5406 +/- ##
=========================================
Coverage 53.98% 53.99%
Complexity 419 419
=========================================
Files 1161 1161
Lines 20821 20827 +6
Branches 3759 3761 +2
=========================================
+ Hits 11241 11246 +5
Misses 8867 8867
- Partials 713 714 +1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/5406?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...egy/algorithm/sharding/RangeShardingAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/5406/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9zdHJhdGVneS9hbGdvcml0aG0vc2hhcmRpbmcvUmFuZ2VTaGFyZGluZ0FsZ29yaXRobS5qYXZh) | `86.66% <95.00%> (-0.52%)` | `0.00 <0.00> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5406?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5406?src=pr&el=footer). Last update [dda2c5f...4c49e49](https://codecov.io/gh/apache/shardingsphere/pull/5406?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on pull request #5406: optimize performance of partitionRangeMap initialization
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on pull request #5406:
URL: https://github.com/apache/shardingsphere/pull/5406#issuecomment-623058343
> Hi @strongduanmu Sorry to review late.
> Presently, this algorithm is perfect! Moreover, if you like, another range algorithm (sharding by particular volume) is welcome to contribute. However, just consider scheduling it, for it is time to enjoy your holiday! 😉
@tristaZero Thank you for this review, I will submit another PR for the new range sharding algorithm later. 😊
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls commented on pull request #5406: optimize performance of partitionRangeMap initialization
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #5406:
URL: https://github.com/apache/shardingsphere/pull/5406#issuecomment-622445924
## Pull Request Test Coverage Report for [Build 11389](https://coveralls.io/builds/30494194)
* **20** of **20** **(100.0%)** changed or added relevant lines in **1** file are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage increased (+**0.01%**) to **57.488%**
---
| Totals | [](https://coveralls.io/builds/30494194) |
| :-- | --: |
| Change from base [Build 11387](https://coveralls.io/builds/30481066): | 0.01% |
| Covered Lines: | 11973 |
| Relevant Lines: | 20827 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on pull request #5406: optimize performance of partitionRangeMap initialization
Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #5406:
URL: https://github.com/apache/shardingsphere/pull/5406#issuecomment-623056666
Hi @strongduanmu Sorry to review late.
Presently, this algorithm is perfect! Moreover, if you like, another range algorithm (sharding by particular volume) is welcome to contribute. However, just consider scheduling it, for it is time to enjoy your holiday! 😉
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org