You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/19 16:43:34 UTC

[GitHub] [airflow] kaxil commented on a change in pull request #13763: BaseBranchOperator will push to xcom by default.

kaxil commented on a change in pull request #13763:
URL: https://github.com/apache/airflow/pull/13763#discussion_r560321466



##########
File path: airflow/operators/branch.py
##########
@@ -49,4 +49,6 @@ def choose_branch(self, context: Dict) -> Union[str, Iterable[str]]:
         raise NotImplementedError
 
     def execute(self, context: Dict):
-        self.skip_all_except(context['ti'], self.choose_branch(context))
+        branches_to_execute = self.choose_branch(context)
+        self.skip_all_except(context['ti'], branches_to_execute)
+        return branches_to_execute

Review comment:
       This means it will always push right, even if do_xcom_push is False




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org