You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/05/05 12:42:33 UTC

[GitHub] [dolphinscheduler] hstdream opened a new pull request, #9651: Add example and notice about task type Stored Procedure

hstdream opened a new pull request, #9651:
URL: https://github.com/apache/dolphinscheduler/pull/9651

   <!--Thanks very much for contributing to Apache DolphinScheduler. Please review https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html before opening a pull request.-->
   
   
   ## Purpose of the pull request
   
   this pr close: #8019 
   
   ## Brief change log
   
   <!--*(for example:)*
     - *Add maven-checkstyle-plugin to root pom.xml*
   -->
   ## Verify this pull request
   
   <!--*(Please pick either of the following options)*-->
   
   This pull request is code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   <!--*(example:)*
     - *Added dolphinscheduler-dao tests for end-to-end.*
     - *Added CronUtilsTest to verify the change.*
     - *Manually verified the change by testing locally.* -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] caishunfeng commented on pull request #9651: Add example and notice about task type Stored Procedure

Posted by "caishunfeng (via GitHub)" <gi...@apache.org>.
caishunfeng commented on PR #9651:
URL: https://github.com/apache/dolphinscheduler/pull/9651#issuecomment-1413093689

   I close this pr due to already implemented in dev branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] hstdream commented on pull request #9651: Add example and notice about task type Stored Procedure

Posted by GitBox <gi...@apache.org>.
hstdream commented on PR #9651:
URL: https://github.com/apache/dolphinscheduler/pull/9651#issuecomment-1105053678

   this pr close: #8019


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] hstdream closed pull request #9651: Add example and notice about task type Stored Procedure

Posted by GitBox <gi...@apache.org>.
hstdream closed pull request #9651: Add example and notice about task type Stored Procedure
URL: https://github.com/apache/dolphinscheduler/pull/9651


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #9651: Add example and notice about task type Stored Procedure

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #9651:
URL: https://github.com/apache/dolphinscheduler/pull/9651#issuecomment-1140818590

   Hi @hstdream CI still failed, you should remove the images '/img/tasks/demo/procedure_task1.png', '/img/procedure-en.png', '/img/procedure_edit.png', '/img/tasks/demo/procedure_task2.png'  in `img` directory.
   
   And change screenshot language from Chinese to English


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] caishunfeng commented on pull request #9651: Add example and notice about task type Stored Procedure

Posted by GitBox <gi...@apache.org>.
caishunfeng commented on PR #9651:
URL: https://github.com/apache/dolphinscheduler/pull/9651#issuecomment-1118253261

   @hstdream Please resolve conflicts.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #9651: Add example and notice about task type Stored Procedure

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on code in PR #9651:
URL: https://github.com/apache/dolphinscheduler/pull/9651#discussion_r873297575


##########
docs/docs/zh/guide/task/stored-procedure.md:
##########
@@ -1,12 +1,47 @@
 # 存储过程节点
 
+## 综述
+
+`PROCEDURE` 任务类型，用于执行存储过程的程序
+
+## 创建任务
+
 - 根据选择的数据源，执行存储过程。
 > 拖动工具栏中的![PNG](https://analysys.github.io/easyscheduler_docs_cn/images/toolbar_PROCEDURE.png)任务节点到画板中，如下图所示：

Review Comment:
   Please change this png link from `analysys.github.io` to our local file like you add then in its `Task Example` section



##########
docs/docs/en/guide/task/stored-procedure.md:
##########
@@ -1,4 +1,10 @@
-# Stored Procedure
+# PROCEDURE
+
+## Overview
+
+`PROCEDURE` task type, the program used to execute the stored procedure
+
+## Create Task
 
 - Execute the stored procedure according to the selected DataSource.

Review Comment:
   We should also add how to create task like others `- Drag from the toolbar <img src="/img/tasks/icons/procedure.png" width="25"/> to the canvas.`



##########
docs/configs/docsdev.js:
##########
@@ -470,7 +470,7 @@ export default {
                                 link: '/zh-cn/docs/dev/user_doc/guide/task/dependent.html',
                             },
                             {
-                                title: 'Stored Procedure',
+                                title: 'Procedure,
                                 link: '/zh-cn/docs/dev/user_doc/guide/task/stored-procedure.html',

Review Comment:
   I suggest we should change the task file name from `stored-procedure` to `procedure` to keep the file name same as the content title of first line
   ```suggestion
                                   link: '/zh-cn/docs/dev/user_doc/guide/task/procedure.html',
   ```



##########
docs/configs/docsdev.js:
##########
@@ -470,7 +470,7 @@ export default {
                                 link: '/zh-cn/docs/dev/user_doc/guide/task/dependent.html',
                             },
                             {
-                                title: 'Stored Procedure',
+                                title: 'Procedure,
                                 link: '/zh-cn/docs/dev/user_doc/guide/task/stored-procedure.html',

Review Comment:
   Please also change the EN document



##########
docs/docs/en/guide/task/stored-procedure.md:
##########
@@ -1,4 +1,10 @@
-# Stored Procedure
+# PROCEDURE

Review Comment:
   ```suggestion
   # Procedure
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #9651: Add example and notice about task type Stored Procedure

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on code in PR #9651:
URL: https://github.com/apache/dolphinscheduler/pull/9651#discussion_r855713533


##########
docs/docs/zh/guide/task/stored-procedure.md:
##########
@@ -7,6 +7,33 @@
    <img src="/img/procedure_edit.png" width="80%" />
  </p>
 
-- 数据源：存储过程的数据源类型支持MySQL和POSTGRESQL两种，选择对应的数据源
-- 方法：是存储过程的方法名称
-- 自定义参数：存储过程的自定义参数类型支持IN、OUT两种，数据类型支持VARCHAR、INTEGER、LONG、FLOAT、DOUBLE、DATE、TIME、TIMESTAMP、BOOLEAN九种数据类型
+- 节点名称：设置任务节点的名称，一个工作流定义中的节点名称是唯一的。
+- 运行标志：标识这个结点是否能正常调度，如果不需要执行，可以打开禁止执行开关。
+- 描述：描述该节点的功能。
+- 任务优先级：worker 线程数不足时，根据优先级从高到低依次执行，优先级一样时根据先进先出原则执行。
+- Worker 分组：任务分配给 worker 组的机器执行，选择Default，会随机选择一台 worker 机执行。

Review Comment:
   Your Chinese docs should also use the highlight as English `Default`, just like your doc in English.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] codecov-commenter commented on pull request #9651: Add example and notice about task type Stored Procedure

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #9651:
URL: https://github.com/apache/dolphinscheduler/pull/9651#issuecomment-1140627213

   # [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/9651?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9651](https://codecov.io/gh/apache/dolphinscheduler/pull/9651?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e7752c7) into [dev](https://codecov.io/gh/apache/dolphinscheduler/commit/13af2adfc150e6e16ce07c5d1abeeb25f9cd9340?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (13af2ad) will **decrease** coverage by `0.03%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@             Coverage Diff              @@
   ##                dev    #9651      +/-   ##
   ============================================
   - Coverage     41.17%   41.13%   -0.04%     
   + Complexity     4760     4757       -3     
   ============================================
     Files           855      855              
     Lines         34621    34621              
     Branches       3826     3826              
   ============================================
   - Hits          14254    14241      -13     
   - Misses        18991    19003      +12     
   - Partials       1376     1377       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dolphinscheduler/pull/9651?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...r/plugin/registry/zookeeper/ZookeeperRegistry.java](https://codecov.io/gh/apache/dolphinscheduler/pull/9651/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1yZWdpc3RyeS9kb2xwaGluc2NoZWR1bGVyLXJlZ2lzdHJ5LXBsdWdpbnMvZG9scGhpbnNjaGVkdWxlci1yZWdpc3RyeS16b29rZWVwZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcGx1Z2luL3JlZ2lzdHJ5L3pvb2tlZXBlci9ab29rZWVwZXJSZWdpc3RyeS5qYXZh) | `48.21% <0.00%> (-8.04%)` | :arrow_down: |
   | [...e/dolphinscheduler/remote/NettyRemotingClient.java](https://codecov.io/gh/apache/dolphinscheduler/pull/9651/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL05ldHR5UmVtb3RpbmdDbGllbnQuamF2YQ==) | `50.70% <0.00%> (-2.82%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/9651?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/9651?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [13af2ad...e7752c7](https://codecov.io/gh/apache/dolphinscheduler/pull/9651?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #9651: Add example and notice about task type Stored Procedure

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on code in PR #9651:
URL: https://github.com/apache/dolphinscheduler/pull/9651#discussion_r858233540


##########
docs/docs/en/guide/task/stored-procedure.md:
##########
@@ -8,6 +8,32 @@
    <img src="/img/procedure-en.png" width="80%" />
  </p>
 
-- DataSource: The DataSource type of the stored procedure supports MySQL and POSTGRESQL, select the corresponding DataSource.
-- Method: The method name of the stored procedure.
-- Custom parameters: The custom parameter types of the stored procedure support `IN` and `OUT`, and the data types support: VARCHAR, INTEGER, LONG, FLOAT, DOUBLE, DATE, TIME, TIMESTAMP and BOOLEAN.
\ No newline at end of file
+- Node name: The node name in a workflow definition is unique.

Review Comment:
   https://raw.githubusercontent.com/apache/dolphinscheduler/dev/docs/docs/en/guide/task/sql.md @hstdream 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] caishunfeng closed pull request #9651: Add example and notice about task type Stored Procedure

Posted by "caishunfeng (via GitHub)" <gi...@apache.org>.
caishunfeng closed pull request #9651: Add example and notice about task type Stored Procedure
URL: https://github.com/apache/dolphinscheduler/pull/9651


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #9651: Add example and notice about task type Stored Procedure

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #9651:
URL: https://github.com/apache/dolphinscheduler/pull/9651#issuecomment-1131261963

   @hstdream CI failed, it is seem your have some unused imgs, and some deadlink in your change


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #9651: Add example and notice about task type Stored Procedure

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on code in PR #9651:
URL: https://github.com/apache/dolphinscheduler/pull/9651#discussion_r855715136


##########
docs/configs/docsdev.js:
##########
@@ -119,7 +119,7 @@ export default {
                                 link: '/en-us/docs/dev/user_doc/guide/task/dependent.html',
                             },
                             {
-                                title: 'Stored Procedure',
+                                title: 'PROCEDURE',

Review Comment:
   ```suggestion
                                   title: 'Procedure',
   ```



##########
docs/docs/en/guide/task/stored-procedure.md:
##########
@@ -8,6 +8,32 @@
    <img src="/img/procedure-en.png" width="80%" />
  </p>
 
-- DataSource: The DataSource type of the stored procedure supports MySQL and POSTGRESQL, select the corresponding DataSource.
-- Method: The method name of the stored procedure.
-- Custom parameters: The custom parameter types of the stored procedure support `IN` and `OUT`, and the data types support: VARCHAR, INTEGER, LONG, FLOAT, DOUBLE, DATE, TIME, TIMESTAMP and BOOLEAN.
\ No newline at end of file
+- Node name: The node name in a workflow definition is unique.
+- Run flag: Identifies whether this node schedules normally, if it does not need to execute, select the `prohibition execution`.
+- Descriptive information: Describe the function of the node.
+- Task priority: When the number of worker threads is insufficient, execute in the order of priority from high to low, and tasks with the same priority will execute in a first-in first-out order.
+- Worker grouping: Assign tasks to the machines of the worker group to execute. If `Default` is selected, randomly select a worker machine for execution.
+- Environment Name: Configure the environment name in which run the script.
+- Times of failed retry attempts: The number of times the task failed to resubmit.
+- Failed retry interval: The time interval (unit minute) for resubmitting the task after a failed task.
+- Delayed execution time: The time (unit minute) that a task delays in execution.
+- Timeout alarm: Check the timeout alarm and timeout failure. When the task runs exceed the "timeout", an alarm email will send and the task execution will fail.
+- DataSource: The DataSource type of the stored procedure supports MySQL,POSTGRESQL,HIVE,SPARK,CLICKHOUSE,ORACLE,SQLSERVER,DB2 and PRESTO, select the corresponding DataSource.

Review Comment:
   ```suggestion
   - DataSource: The DataSource type of the stored procedure supports MySQL,POSTGRESQL,HIVE,SPARK,CLICKHOUSE,ORACLE,SQLSERVER,DB2 and PRESTO.
   ```



##########
docs/configs/docsdev.js:
##########
@@ -433,7 +433,7 @@ export default {
                                 link: '/zh-cn/docs/dev/user_doc/guide/task/dependent.html',
                             },
                             {
-                                title: 'Stored Procedure',
+                                title: 'PROCEDURE',

Review Comment:
   ```suggestion
                                   title: 'Procedure,
   ```



##########
docs/docs/en/guide/task/stored-procedure.md:
##########
@@ -8,6 +8,32 @@
    <img src="/img/procedure-en.png" width="80%" />
  </p>
 
-- DataSource: The DataSource type of the stored procedure supports MySQL and POSTGRESQL, select the corresponding DataSource.
-- Method: The method name of the stored procedure.
-- Custom parameters: The custom parameter types of the stored procedure support `IN` and `OUT`, and the data types support: VARCHAR, INTEGER, LONG, FLOAT, DOUBLE, DATE, TIME, TIMESTAMP and BOOLEAN.
\ No newline at end of file
+- Node name: The node name in a workflow definition is unique.

Review Comment:
   you should change the document like https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/guide/task/sql.md. We have section `Overview ` and section `Create DataSource`



##########
docs/configs/docsdev.js:
##########
@@ -433,7 +433,7 @@ export default {
                                 link: '/zh-cn/docs/dev/user_doc/guide/task/dependent.html',
                             },
                             {
-                                title: 'Stored Procedure',
+                                title: 'PROCEDURE',

Review Comment:
   If you change the sidebar title, you should also change the title in content `Stored Prcedure`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #9651: Add example and notice about task type Stored Procedure

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on code in PR #9651:
URL: https://github.com/apache/dolphinscheduler/pull/9651#discussion_r858231622


##########
docs/docs/zh/guide/task/stored-procedure.md:
##########
@@ -7,6 +7,33 @@
    <img src="/img/procedure_edit.png" width="80%" />
  </p>
 
-- 数据源：存储过程的数据源类型支持MySQL和POSTGRESQL两种，选择对应的数据源
-- 方法：是存储过程的方法名称
-- 自定义参数：存储过程的自定义参数类型支持IN、OUT两种，数据类型支持VARCHAR、INTEGER、LONG、FLOAT、DOUBLE、DATE、TIME、TIMESTAMP、BOOLEAN九种数据类型
+- 节点名称：设置任务节点的名称，一个工作流定义中的节点名称是唯一的。
+- 运行标志：标识这个结点是否能正常调度，如果不需要执行，可以打开禁止执行开关。
+- 描述：描述该节点的功能。
+- 任务优先级：worker 线程数不足时，根据优先级从高到低依次执行，优先级一样时根据先进先出原则执行。
+- Worker 分组：任务分配给 worker 组的机器执行，选择Default，会随机选择一台 worker 机执行。

Review Comment:
   `Default`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org