You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/05/25 09:08:37 UTC

[GitHub] [shardingsphere] yanyzy opened a new pull request #5780: Rename example service to fix the naming conflict between example and spring boot starter

yanyzy opened a new pull request #5780:
URL: https://github.com/apache/shardingsphere/pull/5780


   The rule is named shadow/encrypt and it will conflict with example service
   ```
   @Bean
       @ConfigurationProperties(prefix = "spring.shardingsphere.rules.shadow")
       @ConditionalOnClass(YamlShadowRuleConfiguration.class)
       @Conditional(ShadowSpringBootCondition.class)
       public YamlRuleConfiguration shadow() {
           return new YamlShadowRuleConfiguration();
       }
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter commented on pull request #5780: Rename example service to fix the naming conflict between example and spring boot starter

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #5780:
URL: https://github.com/apache/shardingsphere/pull/5780#issuecomment-633487343


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5780?src=pr&el=h1) Report
   > Merging [#5780](https://codecov.io/gh/apache/shardingsphere/pull/5780?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/0fbf7d7c4ccca5c854aa8ba43b8f17c5c9d2c357&el=desc) will **decrease** coverage by `0.07%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/5780/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/5780?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5780      +/-   ##
   ============================================
   - Coverage     53.04%   52.96%   -0.08%     
     Complexity      437      437              
   ============================================
     Files          1178     1179       +1     
     Lines         20721    20754      +33     
     Branches       3736     3739       +3     
   ============================================
   + Hits          10991    10993       +2     
   - Misses         9059     9090      +31     
     Partials        671      671              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/5780?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...dingsphere/cluster/state/ClusterStateInstance.java](https://codecov.io/gh/apache/shardingsphere/pull/5780/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1jbHVzdGVyL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItc3RhdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2NsdXN0ZXIvc3RhdGUvQ2x1c3RlclN0YXRlSW5zdGFuY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...er/heartbeat/event/HeartBeatDetectNoticeEvent.java](https://codecov.io/gh/apache/shardingsphere/pull/5780/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1jbHVzdGVyL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItaGVhcnRiZWF0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9jbHVzdGVyL2hlYXJ0YmVhdC9ldmVudC9IZWFydEJlYXREZXRlY3ROb3RpY2VFdmVudC5qYXZh) | `100.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...e/shardingsphere/cluster/facade/ClusterFacade.java](https://codecov.io/gh/apache/shardingsphere/pull/5780/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1jbHVzdGVyL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItZmFjYWRlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9jbHVzdGVyL2ZhY2FkZS9DbHVzdGVyRmFjYWRlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5780?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5780?src=pr&el=footer). Last update [0fbf7d7...983dd23](https://codecov.io/gh/apache/shardingsphere/pull/5780?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu merged pull request #5780: Rename example service to fix the naming conflict between example and spring boot starter

Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #5780:
URL: https://github.com/apache/shardingsphere/pull/5780


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org