You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/01/29 00:29:09 UTC
[GitHub] [hbase] bharathv commented on a change in pull request #1103:
HBASE-23753 Update of errorprone generated failures
bharathv commented on a change in pull request #1103: HBASE-23753 Update of errorprone generated failures
URL: https://github.com/apache/hbase/pull/1103#discussion_r372132709
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java
##########
@@ -152,12 +153,11 @@ public long getSeqid() {
* priority beyond FIFO, they should override {@link #getPriority()}.
*/
@Override
- public int compareTo(Runnable o) {
- EventHandler eh = (EventHandler)o;
- if(getPriority() != eh.getPriority()) {
- return (getPriority() < eh.getPriority()) ? -1 : 1;
+ public int compareTo(EventHandler o) {
+ if(getPriority() != o.getPriority()) {
Review comment:
nit: include a null check in the beginning for o?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services