[GitHub] [incubator-tvm] antinucleon commented on pull request #6854: [RELAY,TOPI] Add scatter_nd op

[GitBox <gi...@apache.org>]

antinucleon commented on pull request #6854:
URL: https://github.com/apache/incubator-tvm/pull/6854#issuecomment-722140534


   > Can you try to fix the CI errors? Left some comments but overall looks really good to me, +1 on the thorough documentation!
   > 
   > For reference, this is based off of MXNet's `scatter_nd` (https://mxnet.apache.org/versions/1.6/api/r/docs/api/mx.symbol.scatter_nd.html).
   > Given the warning about non-determinism there we may want to make a comment here as well.
   > 
   > Do the semantics of MXNet's `scatter_nd` differ from Tensorflow (https://www.tensorflow.org/api_docs/python/tf/scatter_nd) at all?
   
   MXNet `scatter_nd` semantic is a little bit different to TF's semantic. Similarly, @tkonolige points out this thread: https://discuss.tvm.apache.org/t/gather-nd-semantics/6243/6 As long as scatter is not a numpy op, if it is only a transpose difference I think it is probably fine.  


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org