You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Keith Wannamaker <Ke...@Wannamaker.org> on 2001/01/26 22:43:56 UTC
[PATCH] Ajpv13 webdav support
This is a patch against cvs head to add support to ajpv13
for webdav methods:
http://www.apache.org/~keith/jk/webdav1.txt
Also, this is a patch against cvs head to update the win32
project files to reflect the new directory structure:
http://www.apache.org/~keith/jk/win32.txt
I'd be happy to backport both patches back to the 3.2 branch
if they could get rolled with the pending release of 3.2.2.
Keith
[PATCH] Ajpv13 read() bug
Posted by Keith Wannamaker <Ke...@Wannamaker.org>.
Ajpv13's read() is returning signed data to the servlet.
This is a problem (especially with, how did you guess,
binary file uploads) because byte 0xFF will be mistaken as EOF.
The solution is to return legal data bytes unsigned by
casting to char.
The 3.3 patch is here-
http://www.apache.org/~keith/jk/signed_error/unsigned33.txt
For details on reproducing the bug and a patch for 3.2:
http://www.apache.org/~keith/jk/signed_error/
Keith
RE: [PATCH] Ajpv13 webdav support
Posted by James Courtney <ja...@yahoo.com>.
Aha, I see. I'll look forward to 3.3 then.
Thanks,
Jamey
-----Original Message-----
From: Keith Wannamaker [mailto:Keith@Wannamaker.org]
Sent: Monday, January 29, 2001 12:54 PM
To: tomcat-dev@jakarta.apache.org
Cc: jamescourtney_1999@yahoo.com
Subject: RE: [PATCH] Ajpv13 webdav support
In 3.2 I don't think this is possible without changing code.
Try searching for ApacheConfig.
In 3.3, the auto-gen classes are now modules to be specified
in server.xml as ContextInterceptors. Currently only Apache is enabled,
and can be disabled by modifying server.xml.
Keith
-----Original Message-----
From: James Courtney [mailto:jamescourtney_1999@yahoo.com]
Sent: Monday, January 29, 2001 3:44 PM
To: tomcat-dev@jakarta.apache.org
Subject: RE: [PATCH] Ajpv13 webdav support
I know this is rather tangential but I was unaware that it was possible to
turn on and off the auto generation of configuration files by Tomcat. How
do I control this?
Many thanks,
Jamey
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, email: tomcat-dev-help@jakarta.apache.org
_________________________________________________________
Do You Yahoo!?
Get your free @yahoo.com address at http://mail.yahoo.com
RE: [PATCH] Ajpv13 webdav support
Posted by Keith Wannamaker <Ke...@Wannamaker.org>.
In 3.2 I don't think this is possible without changing code.
Try searching for ApacheConfig.
In 3.3, the auto-gen classes are now modules to be specified
in server.xml as ContextInterceptors. Currently only Apache is enabled,
and can be disabled by modifying server.xml.
Keith
-----Original Message-----
From: James Courtney [mailto:jamescourtney_1999@yahoo.com]
Sent: Monday, January 29, 2001 3:44 PM
To: tomcat-dev@jakarta.apache.org
Subject: RE: [PATCH] Ajpv13 webdav support
I know this is rather tangential but I was unaware that it was possible to
turn on and off the auto generation of configuration files by Tomcat. How
do I control this?
Many thanks,
Jamey
RE: [PATCH] Ajpv13 webdav support
Posted by James Courtney <ja...@yahoo.com>.
I know this is rather tangential but I was unaware that it was possible to
turn on and off the auto generation of configuration files by Tomcat. How
do I control this?
Many thanks,
Jamey
-----Original Message-----
From: danmil [mailto:danmil]On Behalf Of Dan Milstein
Sent: Sunday, January 28, 2001 1:40 PM
To: tomcat-dev@jakarta.apache.org
Subject: Re: [PATCH] Ajpv13 webdav support
Keith,
Thanks for all the good work.
A few followups:
1) Which branch. I agree with Marc -- I think we should probably keep this
work on the tomcat HEAD branch (aka TC 3.3). Admittedly, support for the
WebDAV headers is right on the line between a bug and a feature, but I'm
inclined to be conservative about what we put in TC 3.2. If anyone feels
differently, please chime in.
2) As the commit message said, I modified your server.xml to turn the
autogeneration of mod_jk.conf *on* by default, because that is how the
mod_jk-howto specifies things. Just so you know. If you had some specific
reason for setting things up that way, let me know.
-Dan
Keith Wannamaker wrote:
>
> This is a patch against cvs head to add support to ajpv13
> for webdav methods:
>
> http://www.apache.org/~keith/jk/webdav1.txt
>
> Also, this is a patch against cvs head to update the win32
> project files to reflect the new directory structure:
>
> http://www.apache.org/~keith/jk/win32.txt
>
> I'd be happy to backport both patches back to the 3.2 branch
> if they could get rolled with the pending release of 3.2.2.
>
> Keith
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> For additional commands, email: tomcat-dev-help@jakarta.apache.org
--
Dan Milstein // danmil@shore.net
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, email: tomcat-dev-help@jakarta.apache.org
_________________________________________________________
Do You Yahoo!?
Get your free @yahoo.com address at http://mail.yahoo.com
RE: [PATCH] Ajpv13 webdav support
Posted by Keith Wannamaker <Ke...@Wannamaker.org>.
Hi Dan,
Thanks for committing the patches.
|1) Which branch. I agree with Marc -- I think we should probably keep this
|work on the tomcat HEAD branch (aka TC 3.3). Admittedly, support for the
|WebDAV headers is right on the line between a bug and a feature, but I'm
|inclined to be conservative about what we put in TC 3.2. If anyone feels
|differently, please chime in.
In case the consensus is to apply to the 3.2 branch, the equivalent patch is
here:
http://www.apache.org/~keith/jk/webdav32.txt
|2) As the commit message said, I modified your server.xml to turn the
|autogeneration of mod_jk.conf *on* by default, because that is how the
|mod_jk-howto specifies things.
No, that sounds good to me.
Keith
[PATCH] enable Ajpv13 http status text
Posted by Keith Wannamaker <Ke...@Wannamaker.org>.
This patch enables ajpv13 http status text
http://www.apache.org/~keith/jk/status.txt
Keith
Re: [PATCH] Ajpv13 webdav support
Posted by Dan Milstein <da...@shore.net>.
Keith,
Thanks for all the good work.
A few followups:
1) Which branch. I agree with Marc -- I think we should probably keep this
work on the tomcat HEAD branch (aka TC 3.3). Admittedly, support for the
WebDAV headers is right on the line between a bug and a feature, but I'm
inclined to be conservative about what we put in TC 3.2. If anyone feels
differently, please chime in.
2) As the commit message said, I modified your server.xml to turn the
autogeneration of mod_jk.conf *on* by default, because that is how the
mod_jk-howto specifies things. Just so you know. If you had some specific
reason for setting things up that way, let me know.
-Dan
Keith Wannamaker wrote:
>
> This is a patch against cvs head to add support to ajpv13
> for webdav methods:
>
> http://www.apache.org/~keith/jk/webdav1.txt
>
> Also, this is a patch against cvs head to update the win32
> project files to reflect the new directory structure:
>
> http://www.apache.org/~keith/jk/win32.txt
>
> I'd be happy to backport both patches back to the 3.2 branch
> if they could get rolled with the pending release of 3.2.2.
>
> Keith
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> For additional commands, email: tomcat-dev-help@jakarta.apache.org
--
Dan Milstein // danmil@shore.net
[PATCH] ajp13 Apache autoconfig fix
Posted by Keith Wannamaker <Ke...@Wannamaker.org>.
This is a patch against cvs head to autogenerate ajpv13
support for Apache, if the ajpv13 module has been loaded.
Also, update server.xml to show ajpv13 support.
http://www.apache.org/~keith/jk/config.txt
Keith