[Bug 119902] only rename the first master page, the other master pages keep default name

[bu...@apache.org]

https://issues.apache.org/ooo/show_bug.cgi?id=119902

--- Comment #9 from Ma Bingbing <ji...@gmail.com> ---
(In reply to comment #8)
> I am generally in favor of the renaming but have some remarks/questions:
> 
> 1. The patch looks like the first master page is renamed twice.
> 
  Yes, it is a mistake.

> 2. The standard master pages are renamed but what about notes and handout
> master pages?
> 
  The patch works well to all the master pages, not only the standard master
page.

> 3. The indices of original name and new name are different.  Original index
> of page n is n+1 while the index of the new name is n.
> 
  Before this change, the names of all master pages are "docName","Default
1","Default 2",... "Default n"
  After this patch, the names will be "docName", "docName1"
"docName2",...,"docNamen"

> 4. The original names contain the string SD_LT_SEPARATOR ("~LT~") that is
> used in various places.  The new names don't.  Does the code that uses this
> string still work?  
> grep SD_LT_SEPARATOR sd/source/* found 69 places.
  Yes, the code can be worked too. 
  The new names be used to show on the "master pages" view of task span which
just like the first master page before this change.
  The string SD_LT_SEPARATOR may be a symbol of master page name, used to be
different with other names.

-- 
You are receiving this mail because:
You are the assignee for the bug.