You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "kfaraz (via GitHub)" <gi...@apache.org> on 2024/07/08 11:01:35 UTC
[PR] Minor log cleanup in K8sDruidNodeDiscoveryProvider (druid)
kfaraz opened a new pull request, #16701:
URL: https://github.com/apache/druid/pull/16701
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Minor log cleanup in K8sDruidNodeDiscoveryProvider (druid)
Posted by "LakshSingla (via GitHub)" <gi...@apache.org>.
LakshSingla commented on code in PR #16701:
URL: https://github.com/apache/druid/pull/16701#discussion_r1668448762
##########
extensions-core/kubernetes-extensions/src/main/java/org/apache/druid/k8s/discovery/K8sDruidNodeDiscoveryProvider.java:
##########
@@ -285,7 +282,7 @@ private void keepWatching(String namespace, String labelSelector, String resourc
} else {
// Try again by starting the watch from the beginning. This can happen if the
// watch goes bad.
- LOGGER.debug("Received NULL item while watching node type [%s]. Restarting watch.", this.nodeRole);
+ LOGGER.debug("Received NULL item while watching role[%s]. Restarting watch.", this.nodeRole);
Review Comment:
nit, since its debug log anyway
```suggestion
LOGGER.debug("Received null item while watching role[%s]. Restarting watch.", this.nodeRole);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Minor log cleanup in K8sDruidNodeDiscoveryProvider (druid)
Posted by "kfaraz (via GitHub)" <gi...@apache.org>.
kfaraz commented on PR #16701:
URL: https://github.com/apache/druid/pull/16701#issuecomment-2214020074
Thanks for the review, @LakshSingla !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Minor log cleanup in K8sDruidNodeDiscoveryProvider (druid)
Posted by "kfaraz (via GitHub)" <gi...@apache.org>.
kfaraz merged PR #16701:
URL: https://github.com/apache/druid/pull/16701
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org