You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Abraham Elmahrek <ab...@cloudera.com> on 2014/10/03 06:13:54 UTC
Review Request 26309: SQOOP-1561: Sqoop2: Date and DateTime handling
in CSV IDF
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26309/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-1561
https://issues.apache.org/jira/browse/SQOOP-1561
Repository: sqoop-SQOOP-1367
Description
-------
Add joda-time library and use: LocalData and LocalDateTime.
Diffs
-----
connector/connector-sdk/pom.xml f54837d
connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java 02d1a51
connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java 765bedd
pom.xml 9d9b508
Diff: https://reviews.apache.org/r/26309/diff/
Testing
-------
Tested manually.
'mvn clean verify' may fail without SQOOP-1562.
Thanks,
Abraham Elmahrek
Re: Review Request 26309: SQOOP-1561: Sqoop2: Date and DateTime
handling in CSV IDF
Posted by Gwen Shapira <gs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26309/#review55398
-----------------------------------------------------------
Ship it!
http://www.lgtm.in/i/aj3zJMkNp
- Gwen Shapira
On Oct. 3, 2014, 6:53 p.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26309/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2014, 6:53 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1561
> https://issues.apache.org/jira/browse/SQOOP-1561
>
>
> Repository: sqoop-SQOOP-1367
>
>
> Description
> -------
>
> Add joda-time library and use: LocalData and LocalDateTime.
>
>
> Diffs
> -----
>
> connector/connector-sdk/pom.xml f54837d
> connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java 02d1a51
> connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java f5fbab7
> pom.xml 9d9b508
>
> Diff: https://reviews.apache.org/r/26309/diff/
>
>
> Testing
> -------
>
> Tested manually.
>
> 'mvn clean verify' may fail without SQOOP-1562.
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 26309: SQOOP-1561: Sqoop2: Date and DateTime
handling in CSV IDF
Posted by Abraham Elmahrek <ab...@cloudera.com>.
> On Oct. 3, 2014, 8:18 p.m., Gwen Shapira wrote:
> > Looks good. As we discussed, just document somewhere that if FROM and TO datasets are in different timezones, we will read 5pm is FROM timezone and will give a 5pm to the TO connector. The JDBC and HDFS connectors will just write the same 5pm as is with no conversion. Other connectors can have different behavior.
> >
> > Perhaps document it in the user guide and the connector-write guide, both populations should be aware.
>
> Abraham Elmahrek wrote:
> That makes sense. Let's do this in a follow up ticket since we still need to update the documentation to have FROM/TO stuff?
https://issues.apache.org/jira/browse/SQOOP-1565
- Abraham
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26309/#review55388
-----------------------------------------------------------
On Oct. 3, 2014, 6:53 p.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26309/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2014, 6:53 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1561
> https://issues.apache.org/jira/browse/SQOOP-1561
>
>
> Repository: sqoop-SQOOP-1367
>
>
> Description
> -------
>
> Add joda-time library and use: LocalData and LocalDateTime.
>
>
> Diffs
> -----
>
> connector/connector-sdk/pom.xml f54837d
> connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java 02d1a51
> connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java f5fbab7
> pom.xml 9d9b508
>
> Diff: https://reviews.apache.org/r/26309/diff/
>
>
> Testing
> -------
>
> Tested manually.
>
> 'mvn clean verify' may fail without SQOOP-1562.
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 26309: SQOOP-1561: Sqoop2: Date and DateTime
handling in CSV IDF
Posted by Abraham Elmahrek <ab...@cloudera.com>.
> On Oct. 3, 2014, 8:18 p.m., Gwen Shapira wrote:
> > Looks good. As we discussed, just document somewhere that if FROM and TO datasets are in different timezones, we will read 5pm is FROM timezone and will give a 5pm to the TO connector. The JDBC and HDFS connectors will just write the same 5pm as is with no conversion. Other connectors can have different behavior.
> >
> > Perhaps document it in the user guide and the connector-write guide, both populations should be aware.
That makes sense. Let's do this in a follow up ticket since we still need to update the documentation to have FROM/TO stuff?
- Abraham
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26309/#review55388
-----------------------------------------------------------
On Oct. 3, 2014, 6:53 p.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26309/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2014, 6:53 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1561
> https://issues.apache.org/jira/browse/SQOOP-1561
>
>
> Repository: sqoop-SQOOP-1367
>
>
> Description
> -------
>
> Add joda-time library and use: LocalData and LocalDateTime.
>
>
> Diffs
> -----
>
> connector/connector-sdk/pom.xml f54837d
> connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java 02d1a51
> connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java f5fbab7
> pom.xml 9d9b508
>
> Diff: https://reviews.apache.org/r/26309/diff/
>
>
> Testing
> -------
>
> Tested manually.
>
> 'mvn clean verify' may fail without SQOOP-1562.
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 26309: SQOOP-1561: Sqoop2: Date and DateTime
handling in CSV IDF
Posted by Gwen Shapira <gs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26309/#review55388
-----------------------------------------------------------
Looks good. As we discussed, just document somewhere that if FROM and TO datasets are in different timezones, we will read 5pm is FROM timezone and will give a 5pm to the TO connector. The JDBC and HDFS connectors will just write the same 5pm as is with no conversion. Other connectors can have different behavior.
Perhaps document it in the user guide and the connector-write guide, both populations should be aware.
- Gwen Shapira
On Oct. 3, 2014, 6:53 p.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26309/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2014, 6:53 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1561
> https://issues.apache.org/jira/browse/SQOOP-1561
>
>
> Repository: sqoop-SQOOP-1367
>
>
> Description
> -------
>
> Add joda-time library and use: LocalData and LocalDateTime.
>
>
> Diffs
> -----
>
> connector/connector-sdk/pom.xml f54837d
> connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java 02d1a51
> connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java f5fbab7
> pom.xml 9d9b508
>
> Diff: https://reviews.apache.org/r/26309/diff/
>
>
> Testing
> -------
>
> Tested manually.
>
> 'mvn clean verify' may fail without SQOOP-1562.
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 26309: SQOOP-1561: Sqoop2: Date and DateTime
handling in CSV IDF
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26309/
-----------------------------------------------------------
(Updated Oct. 3, 2014, 6:53 p.m.)
Review request for Sqoop.
Bugs: SQOOP-1561
https://issues.apache.org/jira/browse/SQOOP-1561
Repository: sqoop-SQOOP-1367
Description
-------
Add joda-time library and use: LocalData and LocalDateTime.
Diffs (updated)
-----
connector/connector-sdk/pom.xml f54837d
connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java 02d1a51
connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java f5fbab7
pom.xml 9d9b508
Diff: https://reviews.apache.org/r/26309/diff/
Testing
-------
Tested manually.
'mvn clean verify' may fail without SQOOP-1562.
Thanks,
Abraham Elmahrek