[jira] [Commented] (ARTEMIS-2191) Makes PostOfficeImpl::route common paths inlineable

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARTEMIS-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16709026#comment-16709026 ] 

ASF GitHub Bot commented on ARTEMIS-2191:
-----------------------------------------

GitHub user franz1981 opened a pull request:

    https://github.com/apache/activemq-artemis/pull/2449

     ARTEMIS-2191 Makes PostOfficeImpl::route common paths inlineable

    It allows PostOfficeImpl::route to have a better inlining while dealing with common paths that require to be fast.
    It includes some optimisation to reduce the allocations on the hot paths.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/franz1981/activemq-artemis optimized_route

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/2449.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2449
    
----
commit ebdb9b2f193fb3be641e996f9214b1adf29560df
Author: Francesco Nigro <ni...@...>
Date:   2018-12-04T13:14:52Z

    ARTEMIS-2191 Makes PostOfficeImpl::route common paths inlineable
    
    Optimized route

commit 47cbc489f3c2ce9381994b72bd4fa43bf7c1d81f
Author: Francesco Nigro <ni...@...>
Date:   2018-12-04T15:04:53Z

    ARTEMIS-2191 Makes PostOfficeImpl::route common paths inlineable
    
    Optimized processRoute

----


> Makes PostOfficeImpl::route common paths inlineable
> ---------------------------------------------------
>
>                 Key: ARTEMIS-2191
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2191
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 2.7.0
>            Reporter: Francesco Nigro
>            Assignee: Francesco Nigro
>            Priority: Minor
>
> PostOfficeImpl::route is handling very difference cases (eg not durable/durable messages, not durable/durable queues, transactions etc etc) on the same code paths, making the code too big to be inlined when specific code paths are needed.
> The code could be refactored to allow better inlining by using smaller methods and moving away uncommon/slow path from the common one.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)