svn commit: r412651 - /maven/repository-manager/trunk/maven-repository-indexer/src/main/java/org/apache/maven/repository/indexing/AbstractRepositoryIndex.java

[br...@apache.org]

Author: brett
Date: Wed Jun  7 21:35:49 2006
New Revision: 412651

URL: http://svn.apache.org/viewvc?rev=412651&view=rev
Log:
[MRM-118] clean up comments after some investigation

Modified:
    maven/repository-manager/trunk/maven-repository-indexer/src/main/java/org/apache/maven/repository/indexing/AbstractRepositoryIndex.java

Modified: maven/repository-manager/trunk/maven-repository-indexer/src/main/java/org/apache/maven/repository/indexing/AbstractRepositoryIndex.java
URL: http://svn.apache.org/viewvc/maven/repository-manager/trunk/maven-repository-indexer/src/main/java/org/apache/maven/repository/indexing/AbstractRepositoryIndex.java?rev=412651&r1=412650&r2=412651&view=diff
==============================================================================
--- maven/repository-manager/trunk/maven-repository-indexer/src/main/java/org/apache/maven/repository/indexing/AbstractRepositoryIndex.java (original)
+++ maven/repository-manager/trunk/maven-repository-indexer/src/main/java/org/apache/maven/repository/indexing/AbstractRepositoryIndex.java Wed Jun  7 21:35:49 2006
@@ -35,21 +35,21 @@
  * Abstract class for RepositoryIndexers.
  *
  * @author Edwin Punzalan
+ * @todo [BP] overall am not happy with the design of this class and subclasses, but will refactor over time based on how it is used and by assessing how this affects Lucene's performance
  */
 public abstract class AbstractRepositoryIndex
     implements RepositoryIndex
 {
-    // TODO [!] can this be derived from the repository?
+    // TODO: can this be derived from the repository? -- probably a sensible default, but still should be configurable, but this could just be on the call to open()
     private String indexPath;
 
     private boolean indexOpen;
 
-    // TODO [!] why is the writer open for the life, but not the reader? why keep them open that length of time anyway? investigate best practices in Lucene
+    // TODO: why is the writer open for the life, but not the reader? why keep them open that length of time anyway? investigate best practices in Lucene
     private IndexWriter indexWriter;
 
     protected ArtifactRepository repository;
 
-    // TODO [!] is this really needed externally?
     private Analyzer analyzer;
 
     /**
@@ -158,7 +158,7 @@
     protected IndexWriter getIndexWriter()
         throws IOException
     {
-        // TODO [!] why is this allowed to be called before open()?
+        // TODO: why is this allowed to be called before open()?
         if ( indexWriter == null )
         {
             indexWriter = new IndexWriter( indexPath, getAnalyzer(), false );