[GitHub] [ignite] nizhikov commented on a diff in pull request #10275: IGNITE-17717 Fix APP_ID for Log4j2Logger

[GitBox <gi...@apache.org>]

nizhikov commented on code in PR #10275:
URL: https://github.com/apache/ignite/pull/10275#discussion_r983129436


##########
modules/log4j2/src/test/java/org/apache/ignite/logger/log4j2/Log4j2LoggerSelfTest.java:
##########
@@ -146,6 +146,11 @@ public void testSystemNodeId() throws Exception {
 
         assertEquals(U.id8(id), System.getProperty("nodeId"));
         assertEquals("other-app", System.getProperty("appId"));
+
+        new Log4J2Logger(LOG_PATH_TEST).setApplicationAndNode(null, id);
+
+        assertEquals(U.id8(id), System.getProperty("nodeId"));

Review Comment:
   Without the fix test fails with:
   ```
   org.junit.ComparisonFailure: 
   Expected :other-app
   Actual   :ignite
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org