[GitHub] [flink] 1u0 edited a comment on issue #8523: [FLINK-12481][runtime] Invoke timer callback in task thread (via mailbox)

[GitBox <gi...@apache.org>]

1u0 edited a comment on issue #8523: [FLINK-12481][runtime] Invoke timer callback in task thread (via mailbox)
URL: https://github.com/apache/flink/pull/8523#issuecomment-497745492
 
 
   Thanks for review.
   There are some tests failures that are related to this change (I have run only `flink-streaming-java` tests locally). In particular, expectations about execution model in the tests doesn't match the changed one.
   
   More importantly, I have to update user facing documentation regarding timers execution, that would mention such runtime change.
   I'll reopen this PR, after documentation update and if it's aligned.
   
   **Update:** the implementation of `AsyncWaitOperator.processElement` also has to be changed. In particular, it cannot host execution of `userFunction.asyncInvoke` in the main task's thread anymore when there is a timeout. I'll raise this concern in the ticket.
   
   ~~@StefanRRichter, @pnowojski it's up to you if you want to read this PR furhter. On my side, the implementation would not change significantly (modulo the discussion with Stefan regarding timer service callback).~~

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services