You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/10/21 16:13:27 UTC
[GitHub] [incubator-echarts] swsoyee opened a new pull request #13470: add: Japanese i18n file
swsoyee opened a new pull request #13470:
URL: https://github.com/apache/incubator-echarts/pull/13470
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [ ] bug fixing
- [ ] new feature
- [x] others
### What does this PR do?
<!-- USE ONCE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
Support Japanese.
### Fixed issues
<!--
- #xxxx: ...
-->
## Details
### Before: What was the problem?
<!-- DESCRIBE THE BUG OR REQUIREMENT HERE. -->
<!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
### After: How is it fixed in this PR?
<!-- THE RESULT AFTER FIXING AND A SIMPLE EXPLANATION ABOUT HOW IT IS FIXED. -->
<!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
## Usage
### Are there any API changes?
- [ ] The API has been changed.
<!-- LIST THE API CHANGES HERE -->
### Related test cases or examples to use the new APIs
NA.
## Others
### Merging options
- [ ] Please squash the commits into a single one when merge.
### Other information
参考了中文原文和英语翻译的基础上选择的术语，且所有日语术语皆经过了详细的学术调研，应该没什么问题。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] swsoyee commented on pull request #13470: add: Japanese i18n file
Posted by GitBox <gi...@apache.org>.
swsoyee commented on pull request #13470:
URL: https://github.com/apache/incubator-echarts/pull/13470#issuecomment-714196078
@plainheart Sorry for the delay, translation have been added, also switch the target branch and moved the file into `src/i18n` directory.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] plainheart commented on pull request #13470: add: Japanese i18n file
Posted by GitBox <gi...@apache.org>.
plainheart commented on pull request #13470:
URL: https://github.com/apache/incubator-echarts/pull/13470#issuecomment-714177980
Hi, there is some work to be done
- [ ] Move the translation file to https://github.com/apache/incubator-echarts/tree/next/src/i18n/langJA.ts
- [ ] Add translations for [time](https://github.com/apache/incubator-echarts/blob/next/src/i18n/langEN.ts#L25-L40) section.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] plainheart edited a comment on pull request #13470: add: Japanese i18n file
Posted by GitBox <gi...@apache.org>.
plainheart edited a comment on pull request #13470:
URL: https://github.com/apache/incubator-echarts/pull/13470#issuecomment-714177980
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] plainheart commented on pull request #13470: add: Japanese i18n file
Posted by GitBox <gi...@apache.org>.
plainheart commented on pull request #13470:
URL: https://github.com/apache/incubator-echarts/pull/13470#issuecomment-714113701
Thank you for providing the Japanese translation.
We are working on the release of the next version 5.0. Would you mind moving this commit to the `next` branch?
All the language source files are in https://github.com/apache/incubator-echarts/tree/next/src/i18n
https://github.com/apache/incubator-echarts/blob/next/src/i18n/langEN.ts is a template for your reference.
Thanks again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang merged pull request #13470: add: Japanese i18n file
Posted by GitBox <gi...@apache.org>.
pissang merged pull request #13470:
URL: https://github.com/apache/incubator-echarts/pull/13470
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org