You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by ha...@apache.org on 2026/01/20 12:27:12 UTC

(skywalking-banyandb) branch main updated: Fix property UT not stable (#951)

This is an automated email from the ASF dual-hosted git repository.

hanahmily pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git


The following commit(s) were added to refs/heads/main by this push:
     new fd52592e Fix property UT not stable (#951)
fd52592e is described below

commit fd52592e7db9a347ee64651abfb907dc54eb9ddd
Author: mrproliu <74...@qq.com>
AuthorDate: Tue Jan 20 20:27:07 2026 +0800

    Fix property UT not stable (#951)
    
    * Fix property UT not stable
    
    * fix flags
    
    ---------
    
    Co-authored-by: 吴晟 Wu Sheng <wu...@foxmail.com>
---
 banyand/property/repair.go            | 2 +-
 bydbctl/internal/cmd/property_test.go | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/banyand/property/repair.go b/banyand/property/repair.go
index d0788e8c..381ab1f4 100644
--- a/banyand/property/repair.go
+++ b/banyand/property/repair.go
@@ -1097,7 +1097,7 @@ func (r *repairScheduler) saveHasBuildTree() error {
 	if err != nil {
 		return err
 	}
-	err = os.MkdirAll(path.Dir(r.scheduleBasicFile), storage.FilePerm)
+	err = os.MkdirAll(path.Dir(r.scheduleBasicFile), storage.DirPerm)
 	if err != nil {
 		return fmt.Errorf("creating directory for repair build tree file %s failure: %w", r.scheduleBasicFile, err)
 	}
diff --git a/bydbctl/internal/cmd/property_test.go b/bydbctl/internal/cmd/property_test.go
index 07755702..1459f1c0 100644
--- a/bydbctl/internal/cmd/property_test.go
+++ b/bydbctl/internal/cmd/property_test.go
@@ -758,7 +758,8 @@ var _ = Describe("Property Cluster Resilience with 5 Data Nodes", func() {
 		for i := 0; i < nodeCount; i++ {
 			By(fmt.Sprintf("Starting data node %d", i))
 			nodeIDs[i], nodeRepairAddrs[i], closeNodes[i] = setup.DataNodeFromDataDir(ep, nodeDirs[i],
-				"--property-repair-enabled=true", "--property-repair-quick-build-tree-time=1s")
+				"--property-repair-enabled=true", "--property-repair-quick-build-tree-time=1s",
+				"--property-repair-build-tree-cron=@every 2s")
 			// Update node ID to use 127.0.0.1
 			_, nodePort, found := strings.Cut(nodeIDs[i], ":")
 			Expect(found).To(BeTrue())