You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/14 09:58:33 UTC
[GitHub] [airflow] brki opened a new pull request, #25710: postgres provider: use non-binary psycopg2
brki opened a new pull request, #25710:
URL: https://github.com/apache/airflow/pull/25710
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] brki commented on a diff in pull request #25710: postgres provider: use non-binary psycopg2
Posted by GitBox <gi...@apache.org>.
brki commented on code in PR #25710:
URL: https://github.com/apache/airflow/pull/25710#discussion_r950668374
##########
docs/apache-airflow-providers-postgres/index.rst:
##########
@@ -65,7 +65,7 @@ Package apache-airflow-providers-postgres
`PostgreSQL <https://www.postgresql.org/>`__
-Release: 5.2.0
+Release: 6.0.0
Review Comment:
@potiuk I considered it a breaking change because it will break for some people, because it introduces new operating system dependencies, that were not necessarily present before. For example on Debian-based distros, libpq-dev is necessary. This is the case for the slime docker images, for example airflow:slim-2.3.3-python3.10 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] brki commented on pull request #25710: postgres provider: use non-binary psycopg2
Posted by GitBox <gi...@apache.org>.
brki commented on PR #25710:
URL: https://github.com/apache/airflow/pull/25710#issuecomment-1221268038
OK. Thanks for the explanation! I'll adjust it later.
On Sat, 20 Aug 2022, 11:22 Jarek Potiuk ***@***.***> wrote:
> ***@***.**** commented on this pull request.
> ------------------------------
>
> In docs/apache-airflow-providers-postgres/index.rst
> <https://github.com/apache/airflow/pull/25710#discussion_r950673413>:
>
> > @@ -65,7 +65,7 @@ Package apache-airflow-providers-postgres
> `PostgreSQL <https://www.postgresql.org/>`__
>
>
> -Release: 5.2.0
> +Release: 6.0.0
>
> This is not what we consider as breaking. Dependency changes are not
> introducing. Our SemVer rules state (see readme)
>
> Airflow: SemVer rules apply to core airflow only (excludes any changes to
> providers). Changing limits for versions of Airflow dependencies is not a
> breaking change on its own.
>
> And while this is not changing the version but other 'variant' of the same
> dependency, this only affect how you install airflow. And it is not
> breaking the 'use' of Airflow which is the important factor for
> breaking/non breaking decision.
>
> The main thing here that changes that are only affecting the way how you
> install Airfloe are not really 'breaking' any user code or ways how you use
> airflow. If for any reason you cannot install Airflow new version, you just
> cannot install it and you don't break anything. Once you installed it, it
> works without changes. So it does not break anything.
>
> If you follow the logic of 'dependencies are breaking changed' then it
> basically would mean than any release where any dependency change is
> breaking - because it might cause troubles when installing Airflow or
> providers.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/airflow/pull/25710#discussion_r950673413>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAFKHGHUKE2TMV6P6DHE6ALV2CPUTANCNFSM56PS4F6A>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] RosterIn commented on a diff in pull request #25710: postgres provider: use non-binary psycopg2
Posted by GitBox <gi...@apache.org>.
RosterIn commented on code in PR #25710:
URL: https://github.com/apache/airflow/pull/25710#discussion_r949899378
##########
docs/apache-airflow-providers-postgres/index.rst:
##########
@@ -65,7 +65,7 @@ Package apache-airflow-providers-postgres
`PostgreSQL <https://www.postgresql.org/>`__
-Release: 5.2.0
+Release: 6.0.0
Review Comment:
I think this file is generated automatically so you shouldn't edit it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] brki commented on a diff in pull request #25710: postgres provider: use non-binary psycopg2
Posted by GitBox <gi...@apache.org>.
brki commented on code in PR #25710:
URL: https://github.com/apache/airflow/pull/25710#discussion_r950668374
##########
docs/apache-airflow-providers-postgres/index.rst:
##########
@@ -65,7 +65,7 @@ Package apache-airflow-providers-postgres
`PostgreSQL <https://www.postgresql.org/>`__
-Release: 5.2.0
+Release: 6.0.0
Review Comment:
@potiuk I considered it a breaking change because it will break for some people, because it introduces new operating system dependencies, that were not necessarily present before. For example on Debian-based distros, libpq-dev is necessary. This is the case for the slim docker images, for example airflow:slim-2.3.3-python3.10 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #25710: postgres provider: use non-binary psycopg2
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #25710:
URL: https://github.com/apache/airflow/pull/25710#issuecomment-1224209464
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #25710: postgres provider: use non-binary psycopg2
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #25710:
URL: https://github.com/apache/airflow/pull/25710
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a diff in pull request #25710: postgres provider: use non-binary psycopg2
Posted by GitBox <gi...@apache.org>.
eladkal commented on code in PR #25710:
URL: https://github.com/apache/airflow/pull/25710#discussion_r950812296
##########
airflow/providers/postgres/provider.yaml:
##########
@@ -22,6 +22,7 @@ description: |
`PostgreSQL <https://www.postgresql.org/>`__
versions:
+ - 6.0.0
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25710: postgres provider: use non-binary psycopg2
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25710:
URL: https://github.com/apache/airflow/pull/25710#issuecomment-1224209186
Cool!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #25710: postgres provider: use non-binary psycopg2
Posted by GitBox <gi...@apache.org>.
potiuk commented on code in PR #25710:
URL: https://github.com/apache/airflow/pull/25710#discussion_r950406056
##########
docs/apache-airflow-providers-postgres/index.rst:
##########
@@ -65,7 +65,7 @@ Package apache-airflow-providers-postgres
`PostgreSQL <https://www.postgresql.org/>`__
-Release: 5.2.0
+Release: 6.0.0
Review Comment:
@RosterIn is right. see note just abiive:
> Please, only add notes to the Changelog just below the "Changelog" header when there are some breaking changes
> and you want to add an explanation to the users on how they are supposed to deal with them.
> The changelog is updated and maintained semi-automatically by release manager.
Also I think the change is not breaking. Dependency change is not a breaking change, bumping min version is not breaking either, and the behaviour is not going to change either
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #25710: postgres provider: use non-binary psycopg2
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #25710:
URL: https://github.com/apache/airflow/pull/25710#issuecomment-1214324148
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #25710: postgres provider: use non-binary psycopg2
Posted by GitBox <gi...@apache.org>.
potiuk commented on code in PR #25710:
URL: https://github.com/apache/airflow/pull/25710#discussion_r950673413
##########
docs/apache-airflow-providers-postgres/index.rst:
##########
@@ -65,7 +65,7 @@ Package apache-airflow-providers-postgres
`PostgreSQL <https://www.postgresql.org/>`__
-Release: 5.2.0
+Release: 6.0.0
Review Comment:
This is not what we consider as breaking. Dependency changes are not introducing. Our SemVer rules state (see readme)
Airflow: SemVer rules apply to core airflow only (excludes any changes to providers). Changing limits for versions of Airflow dependencies is not a breaking change on its own.
And while this is not changing the version but other 'variant' of the same dependency, this only affect how you install airflow. And it is not breaking the 'use' of Airflow which is the important factor for breaking/non breaking decision.
The main thing here that changes that are only affecting the way how you install Airfloe are not really 'breaking' any user code or ways how you use airflow. If for any reason you cannot install Airflow new version, you just cannot install it and you don't break anything. Once you installed it, it works without changes. So it does not break anything.
If you follow the logic of 'dependencies are breaking changes' then it basically would mean than any release where any dependency change is breaking - because it might cause troubles when installing Airflow or providers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #25710: postgres provider: use non-binary psycopg2
Posted by GitBox <gi...@apache.org>.
potiuk commented on code in PR #25710:
URL: https://github.com/apache/airflow/pull/25710#discussion_r950673413
##########
docs/apache-airflow-providers-postgres/index.rst:
##########
@@ -65,7 +65,7 @@ Package apache-airflow-providers-postgres
`PostgreSQL <https://www.postgresql.org/>`__
-Release: 5.2.0
+Release: 6.0.0
Review Comment:
This is not what we consider as breaking. Dependency changes are not introducing. Our SemVer rules state (see readme)
Airflow: SemVer rules apply to core airflow only (excludes any changes to providers). Changing limits for versions of Airflow dependencies is not a breaking change on its own.
And while this is not changing the version but other 'variant' of the same dependency, this only affect how you install airflow. And it is not breaking the 'use' of Airflow which is the important factor for breaking/non breaking decision.
The main thing here that changes that are only affecting the way how you install Airfloe are not really 'breaking' any user code or ways how you use airflow. If for any reason you cannot install Airflow new version, you just cannot install it and you don't break anything. Once you installed it, it works without changes. So it does not break anything.
If you follow the logic of 'dependencies are breaking changed' then it basically would mean than any release where any dependency change is breaking - because it might cause troubles when installing Airflow or providers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] brki commented on a diff in pull request #25710: postgres provider: use non-binary psycopg2
Posted by GitBox <gi...@apache.org>.
brki commented on code in PR #25710:
URL: https://github.com/apache/airflow/pull/25710#discussion_r950667836
##########
docs/apache-airflow-providers-postgres/index.rst:
##########
@@ -65,7 +65,7 @@ Package apache-airflow-providers-postgres
`PostgreSQL <https://www.postgresql.org/>`__
-Release: 5.2.0
+Release: 6.0.0
Review Comment:
Thanks @RosterIn , I've removed the changes to index.rst.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org