You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/03 13:40:28 UTC

[GitHub] [incubator-nuttx] btashton opened a new pull request #2200: lcd: Minor fixes to ssd1306 i2c driver

btashton opened a new pull request #2200:
URL: https://github.com/apache/incubator-nuttx/pull/2200


   ## Summary
   The sendblk function was missing NOSTOP on the first msg of the i2c transaction. This could cause an extra STOP to be inserted
   in the transaction.
   
   ![image](https://user-images.githubusercontent.com/173245/97838443-0f759100-1c95-11eb-8cf1-d4a10b29faeb.png)
   
   
   The driver uses up_mdelay for some timing where it should be using a sleep.
   
   ## Impact
   Proper bulk write transaction is created and less busy time.
   
   ## Testing
   
   Tested using a Adafruit 0.91 OLED display with this controller attached to the simulator.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2200: lcd: Minor fixes to ssd1306 i2c driver

Posted by GitBox <gi...@apache.org>.

xiaoxiang781216 merged pull request #2200:
URL: https://github.com/apache/incubator-nuttx/pull/2200


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org