[PATCH] plugin.xml file for Derby Core plug-in is not in sync with plugin itself

[Susan Cline <ho...@pacbell.net>]

Andrew committed the new derbyclient last week and updated the
snapshot jars, including the Eclipse plug-in.  When I downloaded
the derby_core_plugin_10.1.0.165185.zip file I noticed that
the plugin itself now contains derbyclient.jar, but the plugin.xml does not
list it as one of the libraries of the plugin.

Without the addition of derbyclient.jar in the plugin.xml,
the derbyclient.jar file can not be used by the plugin.

This patch remediates this problem and allows derbyclient.jar
to be used by the Apache Derby Core 10.1 plug-in.

Tests run: verified the built plugin.xml file is well formatted
and includes derbyclient.jar. Verified, using sysinfo, the jars
contained in the plugins/org.apache.derby.core_10.1.0 directory
are 10.1.0.0 alpha jars.

This is my first patch, and although trivial, if I've done anything 
incorrect
please let me know.  Also, if this patch is acceptable, could a committer
please commit?

Thanks,

Susan

Output of svn stat:
M      java\build\org\apache\derbyBuild\eclipse\DerbyEclipsePlugin.java

Patch attached.

Re: [PATCH] plugin.xml file for Derby Core plug-in is not in sync with plugin itself

[Myrna van Lunteren <m....@gmail.com>]

Hi Susan,

Although it's no big deal with the patch you've submitted, which has
only 1 file, I think normally you want to run svn diff from the top of
the trunk (or branch).

Now, someone applying the patch may have to modify the diff file,
strip stuff off before the 'trunk', as their location for the trunk is
likely not the same.

How did you do this anyway - if I try svn diff from a level up from my
trunk svn tells me '.' is not a working directory?
Myrna

[snip]
> This is my first patch, and although trivial, if I've done anything
> incorrect
> please let me know. 

> Index: C:/derby_src/10.1/trunk/java/build/org/apache/derbyBuild/eclipse/DerbyEclipsePlugin.java
> ===================================================================
> --- C:/derby_src/10.1/trunk/java/build/org/apache/derbyBuild/eclipse/DerbyEclipsePlugin.java    (revision 165362)
> +++ C:/derby_src/10.1/trunk/java/build/org/apache/derbyBuild/eclipse/DerbyEclipsePlugin.java    (working copy)
[snip]