You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2013/11/02 00:52:54 UTC

Re: Review Request 13602: Refactored Future to use shared_ptr.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13602/
-----------------------------------------------------------

(Updated Nov. 1, 2013, 11:52 p.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, Ian Downes, Vinod Kone, and Jiang Yan Xu.


Changes
-------

BenM's comments.


Repository: mesos-git


Description
-------

Replaced manual reference counting with shared_ptr in Future. This allows us to kill some nasty copy and deallocation functions in Future (e.g. cleanup, copy).


Diffs (updated)
-----

  3rdparty/libprocess/include/process/future.hpp e03f8c9 

Diff: https://reviews.apache.org/r/13602/diff/


Testing
-------

make check -j8


Thanks,

Jie Yu

Re: Review Request 13602: Refactored Future to use shared_ptr.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13602/#review28113
-----------------------------------------------------------

Ship it!


Thanks for the cleanup Jie!

- Benjamin Hindman


On Nov. 1, 2013, 11:52 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13602/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2013, 11:52 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Ian Downes, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Replaced manual reference counting with shared_ptr in Future. This allows us to kill some nasty copy and deallocation functions in Future (e.g. cleanup, copy).
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/future.hpp e03f8c9 
> 
> Diff: https://reviews.apache.org/r/13602/diff/
> 
> 
> Testing
> -------
> 
> make check -j8
> 
> 
> Thanks,
> 
> Jie Yu
> 
>